From 334a55b2aa4f54115f1ee105e7932c02ff01d836 Mon Sep 17 00:00:00 2001
From: Tom Najdek <tom@doppnet.com>
Date: Tue, 27 Aug 2024 12:36:20 +0200
Subject: [PATCH] Add an option to disable alternating row colors. Resolves
 #4628.

---
 chrome/content/zotero/components/virtualized-table.jsx     | 3 ++-
 .../content/zotero/preferences/preferences_general.xhtml   | 7 +++++++
 chrome/locale/en-US/zotero/preferences.ftl                 | 3 +++
 scss/components/_item-tree.scss                            | 6 ++++--
 scss/components/_rtfScan.scss                              | 6 ++++--
 5 files changed, 20 insertions(+), 5 deletions(-)

diff --git a/chrome/content/zotero/components/virtualized-table.jsx b/chrome/content/zotero/components/virtualized-table.jsx
index d562847432..de79046b00 100644
--- a/chrome/content/zotero/components/virtualized-table.jsx
+++ b/chrome/content/zotero/components/virtualized-table.jsx
@@ -1258,7 +1258,8 @@ class VirtualizedTable extends React.Component {
 			onMouseLeave: e => this._handleMouseLeave(e),
 			className: cx(["virtualized-table", {
 				resizing: this.state.resizing,
-				'multi-select': this.props.multiSelect
+				'multi-select': this.props.multiSelect,
+				'no-alternating-rows': Zotero.Prefs.get('ui.noAlternatingRows'),
 			}]),
 			id: this.props.id,
 			ref: ref => this._topDiv = ref,
diff --git a/chrome/content/zotero/preferences/preferences_general.xhtml b/chrome/content/zotero/preferences/preferences_general.xhtml
index 19210ebf11..cd2dc668f3 100644
--- a/chrome/content/zotero/preferences/preferences_general.xhtml
+++ b/chrome/content/zotero/preferences/preferences_general.xhtml
@@ -58,6 +58,13 @@
 				</menulist>
 			</hbox>
 
+			<hbox align="center">
+				<checkbox data-l10n-id="preferences-item-pane-disable-alternating-rows"
+					preference="extensions.zotero.ui.noAlternatingRows"
+					native="true"
+				/>
+			</hbox>
+
 			<vbox id="item-pane-header-bib-entry-options" class="indented-pref">
 				<hbox align="center">
 					<label data-l10n-id="preferences-item-pane-header-style"/>
diff --git a/chrome/locale/en-US/zotero/preferences.ftl b/chrome/locale/en-US/zotero/preferences.ftl
index 9cc9809a06..2b98ad47e8 100644
--- a/chrome/locale/en-US/zotero/preferences.ftl
+++ b/chrome/locale/en-US/zotero/preferences.ftl
@@ -51,6 +51,9 @@ preferences-item-pane-header-style = Header Citation Style:
 preferences-item-pane-header-locale = Header Language:
 preferences-item-pane-header-missing-style = Missing style: <{ $shortName }>
 
+preferences-item-pane-disable-alternating-rows =
+    .label = Disable alternating row colors
+
 preferences-locate-library-lookup-intro = Library Lookup can find a resource online using your library’s OpenURL resolver.
 preferences-locate-resolver = Resolver:
 preferences-locate-base-url = Base URL:
diff --git a/scss/components/_item-tree.scss b/scss/components/_item-tree.scss
index c2f3966d87..2e219b04cc 100644
--- a/scss/components/_item-tree.scss
+++ b/scss/components/_item-tree.scss
@@ -79,8 +79,10 @@
 	
 	.virtualized-table, .drag-image-container {
 		.row {
-			&.odd:not(.selected) {
-				background-color: var(--material-stripe);
+			@include state(".virtualized-table:not(.no-alternating-rows)") {
+				&.odd:not(.selected) {
+					background-color: var(--material-stripe);
+				}
 			}
 
 			&.even:not(.selected) {
diff --git a/scss/components/_rtfScan.scss b/scss/components/_rtfScan.scss
index 86daadb57d..e3292f13af 100644
--- a/scss/components/_rtfScan.scss
+++ b/scss/components/_rtfScan.scss
@@ -68,8 +68,10 @@
 
 		.virtualized-table {
 			.row {
-				&.odd:not(.selected) {
-					background-color: var(--material-stripe);
+				@include state(".virtualized-table:not(.no-alternating-rows)") {
+					&.odd:not(.selected) {
+						background-color: var(--material-stripe);
+					}
 				}
 			
 				&.even:not(.selected) {