scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-04 02:31:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Avoid extra calls to attachmentCallback

Browse source
This commit is contained in:
Simon Kornblith 2012-07-24 13:35:28 -04:00
parent 99e5bce87c
commit 2fd8871998
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
chrome/content/zotero/xpcom/connector/translate_item.js
View file

@ -271,6 +271,7 @@ Zotero.Translate.ItemSaver.prototype = {
err = new Error("Unexpected status "+statusCode+" received from server");
}
Zotero.debug("Finished creating items");
for(var i=0; i<uploadAttachments.length; i++) {
var attachment = uploadAttachments[i];
if(err) {
@ -278,7 +279,6 @@ Zotero.Translate.ItemSaver.prototype = {
} else {
attachment.key = newKeys[i];
Zotero.debug("Finished creating items");
if(attachment.linkMode === "linked_url") {
attachmentCallback(attachment, 100);
} else if("data" in attachment) {
@ -343,7 +343,6 @@ Zotero.Translate.ItemSaver.prototype = {
// Validate status
if(status === 0 || attachment.snapshot === false) {
// Failed due to SOP, or we are supposed to be getting a snapshot
attachmentCallback(attachment, 0);
attachment.linkMode = "linked_url";
} else if(status !== 200) {
err = new Error("Server returned unexpected status code "+status);
@ -405,6 +404,7 @@ Zotero.Translate.ItemSaver.prototype = {
attachmentCallback(attachment, false, err);
Zotero.logError(err);
}
return headersValidated;
};
var xhr = new XMLHttpRequest();