scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-03 02:21:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

tagsbox: fix deleted tags reappearing (#5533)

Browse source 
https://forums.zotero.org/discussion/110655/z7-beta-tags-reappear-after-quickly-deleting-them

If a library has many tags and one quickly clicks on "-" button
to deleted multiple tags from an item, the database updates
may not keep up with UI. To address this, save item only
once after a debounce.

Fixes: #5410
This commit is contained in:
abaevbog 2025-10-08 12:37:17 -07:00 • committed by GitHub
parent cc4c8cd191
commit 2e3deb0a21
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
chrome/content/zotero/elements/tagsBox.js
View file

@ -241,7 +241,11 @@
this.remove(tagName);
try {
item.removeTag(tagName);
await item.saveTx();
// Save item after a debounce to avoid triggering multiple
// save operations. If there are many tags in the library,
// db transaction may not keep up with UI changes, and cause
// some deleted rows to reappear.
this._saveItemDebounced(item);
}
catch (e) {
this._forceRenderAll();
@ -638,6 +642,10 @@
}
}
_saveItemDebounced = Zotero.Utilities.debounce(async (item) => {
await item.saveTx();
});
_id(id) {
return this.querySelector(`[id=${id}]`);
}