scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-09-27 01:21:27 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix picking a type for the creator removes the entry. Close #5396

Browse source
This commit is contained in:
Tom Najdek 2025-07-21 13:03:41 +02:00
parent 162fb4d51b
commit 2d4a086819
No known key found for this signature in database
GPG key ID: EEC61A7B4C667D77
1 changed files with 4 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
chrome/content/zotero/elements/itemBox.js
View file

@ -1119,7 +1119,8 @@
rowLabel.appendChild(labelWrapper);
let label = this.createLabelElement({
id: 'creator-type-label-inner',
text: Zotero.getString('creatorTypes.' + Zotero.CreatorTypes.getName(typeID))
text: Zotero.getString('creatorTypes.' + Zotero.CreatorTypes.getName(typeID)),
skipEventHandlers: true,
});
labelWrapper.appendChild(label);
@ -1562,7 +1563,7 @@
return openLink;
}
createLabelElement({ text, id, attributes, classList }) {
createLabelElement({ text, id, attributes, classList, skipEventHandlers = false } = {}) {
let label = document.createElement('label');
label.classList.add('key', ...classList || []);
if (text) label.textContent = text;
@ -1573,7 +1574,7 @@
}
}
// On click of the label, toggle the focus of the value field
if (this.editable) {
if (this.editable && !skipEventHandlers) {
label.addEventListener('mousedown', (event) => {
// Prevent default focus/blur behavior - we implement our own below
event.preventDefault();