From 29fa2f70732511a650c2ff21f6ef606653e4226b Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Mon, 1 Jul 2024 01:32:59 -0400 Subject: [PATCH] LABD: Add test for ignoring a file that already exists under new path --- test/tests/preferences_advancedTest.js | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/test/tests/preferences_advancedTest.js b/test/tests/preferences_advancedTest.js index c64713c689..f158815b30 100644 --- a/test/tests/preferences_advancedTest.js +++ b/test/tests/preferences_advancedTest.js @@ -105,7 +105,29 @@ describe("Advanced Preferences", function () { assert.isFalse(Zotero.Prefs.get('saveRelativeAttachmentPath')); assert.equal(attachment.attachmentPath, file.path); - }) + }); + + it("should ignore attachment with relative path already within new base directory", async function () { + var file = getTestDataDirectory(); + file.append('test.png'); + file = file.path; + + var attachment = await Zotero.Attachments.linkFromFile({ file }); + assert.equal(attachment.attachmentPath, file); + + var basePath = getTestDataDirectory().path; + await setBaseDirectory(basePath); + + var newBasePath = await getTempDirectory(); + await IOUtils.copy(file, PathUtils.joinRelative(newBasePath, 'test.png')); + + await setBaseDirectory(newBasePath); + + assert.equal( + attachment.attachmentPath, + Zotero.Attachments.BASE_PATH_PLACEHOLDER + 'test.png' + ); + }); }) }) })