diff --git a/chrome/content/zotero/overlay.xul b/chrome/content/zotero/overlay.xul index 61091ca1e3..c77b4bdfc8 100644 --- a/chrome/content/zotero/overlay.xul +++ b/chrome/content/zotero/overlay.xul @@ -94,6 +94,6 @@ + modifiers="accel shift" /> diff --git a/chrome/content/zotero/preferences/preferences_keys.js b/chrome/content/zotero/preferences/preferences_keys.js index 3c544cd757..748f05adc2 100644 --- a/chrome/content/zotero/preferences/preferences_keys.js +++ b/chrome/content/zotero/preferences/preferences_keys.js @@ -30,7 +30,7 @@ Zotero_Preferences.Keys = { // Display the appropriate modifier keys for the platform var rows = document.getElementById('zotero-prefpane-keys').getElementsByTagName('row'); for (var i=0; i hasn't been manually changed - // and the pref has been - if (keyElem.getAttribute('key') == 'Z' && keyElem.getAttribute('modifiers') == 'accel alt' - && (zKey != 'Z' || useShift)) { + // Only override the default with the pref if the hasn't + // been manually changed and the pref has been + if (keyElem.getAttribute('key') == 'Z' + && keyElem.getAttribute('modifiers') == 'accel shift' + && zKey != 'Z') { keyElem.setAttribute('key', zKey); - if (useShift) { - keyElem.setAttribute('modifiers', 'accel shift'); - } } } } diff --git a/chrome/content/zotero/zoteroPane.js b/chrome/content/zotero/zoteroPane.js index 6117e958be..2cd3bed8a3 100644 --- a/chrome/content/zotero/zoteroPane.js +++ b/chrome/content/zotero/zoteroPane.js @@ -602,17 +602,14 @@ var ZoteroPane = new function() } } - var useShift = Zotero.isMac; - var key = String.fromCharCode(event.which); if (!key) { Zotero.debug('No key'); return; } - // Ignore modifiers other than Ctrl-Alt or Cmd-Shift - if (!((Zotero.isMac ? event.metaKey : event.ctrlKey) && - (useShift ? event.shiftKey : event.altKey))) { + // Ignore modifiers other than Ctrl-Shift/Cmd-Shift + if (!((Zotero.isMac ? event.metaKey : event.ctrlKey) && event.shiftKey)) { return; } @@ -687,9 +684,7 @@ var ZoteroPane = new function() } } // Use key that's not the modifier as the popup toggle - ZoteroPane_Local.newNote( - useShift ? event.altKey : event.shiftKey, parent - ); + ZoteroPane_Local.newNote(event.altKey, parent); break; case 'toggleTagSelector': ZoteroPane_Local.toggleTagSelector();