From 24b5f2efb49e5c212c1fe9b4bea4bafc053181f0 Mon Sep 17 00:00:00 2001 From: windingwind <33902321+windingwind@users.noreply.github.com> Date: Wed, 19 Jun 2024 14:26:08 +0800 Subject: [PATCH] Assign ItemPane#_itemDetails default tabType (#4261) Fix pinnedPane set to ItemDetails before tabType is assigned not stored to pref fix: #4260 --- chrome/content/zotero/elements/itemDetails.js | 4 ++-- chrome/content/zotero/elements/itemPane.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/chrome/content/zotero/elements/itemDetails.js b/chrome/content/zotero/elements/itemDetails.js index cb1c4ea350..379eb40b66 100644 --- a/chrome/content/zotero/elements/itemDetails.js +++ b/chrome/content/zotero/elements/itemDetails.js @@ -109,11 +109,11 @@ } get tabType() { - return this._tabType; + return this.getAttribute('tabType'); } set tabType(tabType) { - this._tabType = tabType; + this.setAttribute('tabType', tabType); } get collectionTreeRow() { diff --git a/chrome/content/zotero/elements/itemPane.js b/chrome/content/zotero/elements/itemPane.js index 1a6caae80d..72528eb9f0 100644 --- a/chrome/content/zotero/elements/itemPane.js +++ b/chrome/content/zotero/elements/itemPane.js @@ -30,7 +30,7 @@ - +