scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-07 02:58:09 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Clarify variable name in Item#_updateAttachmentStates()

Browse source
This commit is contained in:
Dan Stillman 2025-08-22 02:56:43 -04:00
parent ea3f14f195
commit 2216729721
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
chrome/content/zotero/xpcom/data/item.js
View file

@ -2824,7 +2824,7 @@ Zotero.Item.prototype._updateAttachmentStates = function (exists) {
}
try {
var item = this.ObjectsClass.getByLibraryAndKey(this.libraryID, parentKey);
var parentItem = this.ObjectsClass.getByLibraryAndKey(this.libraryID, parentKey);
}
catch (e) {
if (e instanceof Zotero.Exception.UnloadedDataException) {
@ -2834,16 +2834,18 @@ Zotero.Item.prototype._updateAttachmentStates = function (exists) {
}
throw e;
}
if (!item) {
if (!parentItem) {
Zotero.logError(`Attachment parent ${this.libraryID}/${parentKey} doesn't exist`);
return;
}
if (!this.deleted && item._bestAttachmentState?.key && this.key === item._bestAttachmentState.key) {
item._bestAttachmentState.exists = exists;
if (!this.deleted
&& parentItem._bestAttachmentState?.key
&& this.key === parentItem._bestAttachmentState.key) {
parentItem._bestAttachmentState.exists = exists;
}
else {
item.clearBestAttachmentState();
parentItem.clearBestAttachmentState();
}
};