scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-10-10 03:28:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

Fall back from best-match mode when semantic search is disabled

Browse source 
Rows kept identifying the active mode as bestMatch after the model was
disabled in the preferences, leaving the active filter returning nothing.
Observe the model pref, switch to Fields & Tags, and rerun any active
search.
This commit is contained in:
Dan Stillman 2026-07-20 15:49:58 -04:00 • committed by Bogdan Abaev
parent 44801d65be
commit 1e68872788
1 changed files with 22 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
chrome/content/zotero/elements/quickSearchTextbox.js
View file

@ -67,6 +67,13 @@
this.searchTextbox.value = val;
}
disconnectedCallback() {
if (this._modelPrefObserverID) {
Zotero.Prefs.unregisterObserver(this._modelPrefObserverID);
this._modelPrefObserverID = null;
}
}
connectedCallback() {
let content = document.importNode(this.content, true);
this.append(content);
@ -131,8 +138,22 @@
this._advancedButton = advancedButton;
}
// Disabling semantic search in the preferences invalidates an active
// best-match mode: fall back to Fields & Tags and rerun any active
// search under the new mode
this._modelPrefObserverID = Zotero.Prefs.registerObserver('embeddings.model', () => {
if (Zotero.Prefs.get('search.quicksearch-mode') === 'bestMatch'
&& !Zotero.Embeddings.isEnabled()) {
Zotero.Prefs.set('search.quicksearch-mode', 'fields');
this.updateMode();
if (this.value) {
this.dispatchEvent(new Event('command'));
}
}
});
this.deck = this.firstElementChild;
this.querySelector('.advanced-collapse-button').addEventListener('command', (event) => {
event.stopPropagation();
ZoteroPane.toggleAdvancedSearchState('collapsed');