From 181611eddfe8324584a32771d7956d5f1cf207c7 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Wed, 7 Sep 2011 07:43:27 +0000 Subject: [PATCH] Add an integrity check step for syncDeleteLog entries for nonexistent libraries (which shouldn't be possible) --- chrome/content/zotero/xpcom/schema.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/chrome/content/zotero/xpcom/schema.js b/chrome/content/zotero/xpcom/schema.js index dce1690090..b3a049c1c2 100644 --- a/chrome/content/zotero/xpcom/schema.js +++ b/chrome/content/zotero/xpcom/schema.js @@ -1084,7 +1084,12 @@ Zotero.Schema = new function(){ "SELECT COUNT(*) FROM tags NATURAL JOIN itemTags JOIN items USING (itemID) WHERE IFNULL(tags.libraryID, 0)!=IFNULL(items.libraryID,0)", "SELECT COUNT(*) FROM itemTags WHERE tagID IS NULL", - "SELECT COUNT(*) FROM itemAttachments WHERE charsetID='NULL'" + "SELECT COUNT(*) FROM itemAttachments WHERE charsetID='NULL'", + + // TODO: check 'libraries', not 'groups', but first add a + // migration step to delete 'libraries' rows not in 'groups' + //"SELECT COUNT(*) FROM syncDeleteLog WHERE libraryID != 0 AND libraryID NOT IN (SELECT libraryID FROM libraries)" + "SELECT COUNT(*) FROM syncDeleteLog WHERE libraryID != 0 AND libraryID NOT IN (SELECT libraryID FROM groups)" ]; for each(var sql in queries) {