scriptoriumadmin/zotero
1
0
Fork 0
mirror of https://github.com/zotero/zotero.git synced 2026-09-28 01:31:40 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

new collection dlg: fix menu keyboard nav on win (#5208)

Browse source 
Fixed non-working selection of collections in the
dropdown via keyboard on Windows.

Fixes: #5202
This commit is contained in:
abaevbog 2025-04-15 22:57:13 -07:00 • committed by GitHub
parent f568363098
commit 1459ca210d
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 14 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
chrome/content/zotero/newCollectionDialog.js
View file

@ -48,17 +48,18 @@ var Zotero_New_Collection_Dialog = {
_updateMenu() {
let createInField = document.querySelector('#create-in');
let menupopup = createInField.firstElementChild;
let id = menupopup.id;
// Fascinatingly, clearing the children of the menupopup isn't enough here.
// We have to completely recreate it or it will no longer be willing to open.
menupopup.replaceWith(menupopup = document.createXULElement('menupopup'));
menupopup.id = id;
menupopup.replaceChildren();
let createdNode = Zotero.Utilities.Internal.createMenuForTarget(
Zotero.Libraries.get(this._libraryID),
menupopup,
this._parentCollectionID ? 'C' + this._parentCollectionID : 'L' + this._libraryID,
(event, libraryOrCollection) => {
// if a menu for a collection with children is clicked, close the entire menu,
// otherwise it oddly remains open
if (event.target.tagName == "menu") {
menupopup.hidePopup();
}
this._libraryID = libraryOrCollection.libraryID;
if (libraryOrCollection.objectType === 'collection') {
this._parentCollectionID = libraryOrCollection.id;
@ -66,7 +67,7 @@ var Zotero_New_Collection_Dialog = {
else {
this._parentCollectionID = null;
}
this._updateMenu();
this._updateSelectedCollectionLabel();
},
null
);
@ -75,7 +76,13 @@ var Zotero_New_Collection_Dialog = {
createdNode.replaceWith(...createdNode.menupopup.children);
}
let checkedItem = menupopup.querySelector('[checked="true"]');
this._updateSelectedCollectionLabel();
},
_updateSelectedCollectionLabel() {
let createInField = document.querySelector('#create-in');
let selectedID = this._parentCollectionID ? 'C' + this._parentCollectionID : 'L' + this._libraryID;
let checkedItem = createInField.querySelector(`[value="${selectedID}"]`);
createInField.setAttribute('label', checkedItem?.label || '');
createInField.image = checkedItem?.image;
}