From 0f676dd7206766433d3d692c09ed5d7b62e0d037 Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Wed, 22 Dec 2021 03:42:15 -0500 Subject: [PATCH] Remove lower row height in virtualized table on macOS With the additional PDF icon in the Attachments column from b0ba7e464, might as well have the same amount of spacing to tell the rows apart. --- chrome/content/zotero/collectionTree.jsx | 2 -- chrome/content/zotero/components/virtualized-table.jsx | 7 ------- 2 files changed, 9 deletions(-) diff --git a/chrome/content/zotero/collectionTree.jsx b/chrome/content/zotero/collectionTree.jsx index abb3ef5e52..d978c1444c 100644 --- a/chrome/content/zotero/collectionTree.jsx +++ b/chrome/content/zotero/collectionTree.jsx @@ -344,8 +344,6 @@ var CollectionTree = class CollectionTree extends LibraryTree { ref: ref => this.tree = ref, treeboxRef: ref => this._treebox = ref, renderItem: this.renderItem, - // Extra space on macOS (which gets reduced by 2, so this really means 20) - ...(Zotero.isMac && { rowHeight: 22 }), alternatingRowColors: null, onSelectionChange: this._handleSelectionChange, diff --git a/chrome/content/zotero/components/virtualized-table.jsx b/chrome/content/zotero/components/virtualized-table.jsx index 4964c22215..b8e1e0b12f 100644 --- a/chrome/content/zotero/components/virtualized-table.jsx +++ b/chrome/content/zotero/components/virtualized-table.jsx @@ -297,10 +297,6 @@ class VirtualizedTable extends React.Component { if (!props.disableFontSizeScaling) { this._rowHeight *= Zotero.Prefs.get('fontSize'); } - // A bit less row spacing on macOS - if (Zotero.isMac && this._rowHeight >= (props.rowHeight || DEFAULT_ROW_HEIGHT)) { - this._rowHeight -= 2; - } this.selection = new TreeSelection(this); @@ -1156,9 +1152,6 @@ class VirtualizedTable extends React.Component { } this._rowHeight = this.props.rowHeight || DEFAULT_ROW_HEIGHT; this._rowHeight *= Zotero.Prefs.get('fontSize'); - if (Zotero.isMac && this._rowHeight >= (this.props.rowHeight || DEFAULT_ROW_HEIGHT)) { - this._rowHeight -= 2; - } if (!this._jsWindow) return; this._jsWindow.update(this._getWindowedListOptions());