From 03941dafe0f80cc48334b62254e0133793742fee Mon Sep 17 00:00:00 2001 From: Dan Stillman Date: Wed, 20 Mar 2019 08:52:23 -0400 Subject: [PATCH] Fix tests after 42667e70903 It seems like the Zotero.Utilities.debounce() on handleSearch() in tagSelector.jsx was somehow causing the function to be run without being triggered from the onSearch events, resulting in an extra render. I'm not sure why that was happening, but it's fixed now that there's no longer a debounce() there. --- test/tests/tagSelectorTest.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/test/tests/tagSelectorTest.js b/test/tests/tagSelectorTest.js index 3755b88547..6c52da977f 100644 --- a/test/tests/tagSelectorTest.js +++ b/test/tests/tagSelectorTest.js @@ -200,12 +200,9 @@ describe("Tag Selector", function () { } // Add item with tag to library root - promise = waitForTagSelector(win); - var item = await createDataObject('item'); - await promise - var tagA = Zotero.Utilities.randomString(); var tagB = Zotero.Utilities.randomString(); + var item = createUnsavedDataObject('item'); item.setTags([ { tag: tagA @@ -421,7 +418,7 @@ describe("Tag Selector", function () { var tag2 = Zotero.Utilities.randomString(); var item1 = createUnsavedDataObject('item', { tags: [{ tag: tag1 }] }); var item2 = createUnsavedDataObject('item', { tags: [{ tag: tag2 }] }); - var promise = waitForTagSelector(win, 2); + var promise = waitForTagSelector(win); await Zotero.DB.executeTransaction(async function () { await item1.save(); await item2.save();