scriptoriumadmin/veritas-kanban
1
0
Fork 0
mirror of https://github.com/BradGroux/veritas-kanban.git synced 2026-08-28 02:44:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

test: isolate tracked ignore guard

Browse source
This commit is contained in:
Brad Groux 2026-08-23 20:25:13 -05:00
parent 2cbfd3b215
commit 616cc5a0b7
2 changed files with 59 additions and 66 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
scripts/check-tracked-ignore.mjs
View file

@ -14,15 +14,14 @@ function runGit(args, options = {}) {
return result;
}
export function findIgnoredTrackedFiles(cwd = process.cwd(), env = process.env) {
const tracked = runGit(['ls-files', '-z'], { cwd, env });
export function findIgnoredTrackedFiles(cwd = process.cwd(), gitRunner = runGit) {
const tracked = gitRunner(['ls-files', '-z'], { cwd });
if (tracked.status !== 0) {
throw new Error(`git ls-files failed: ${tracked.stderr.toString('utf8').trim()}`);
}
const ignored = runGit(['check-ignore', '--no-index', '-z', '--stdin'], {
const ignored = gitRunner(['check-ignore', '--no-index', '-z', '--stdin'], {
cwd,
env,
input: tracked.stdout,
});
if (ignored.status === 1) return [];

118
scripts/check-tracked-ignore.test.mjs
View file

@ -1,77 +1,71 @@
import assert from 'node:assert/strict';
import { execFileSync } from 'node:child_process';
import { mkdir, mkdtemp, rm, writeFile } from 'node:fs/promises';
import os from 'node:os';
import path from 'node:path';
import test from 'node:test';
import { findIgnoredTrackedFiles } from './check-tracked-ignore.mjs';
const isolatedGitEnvironment = Object.fromEntries(
Object.entries(process.env).filter(([key]) => !key.startsWith('GIT_'))
);
async function createRepository() {
const root = await mkdtemp(path.join(os.tmpdir(), 'veritas-tracked-ignore-'));
execFileSync('git', ['init', '--quiet'], { cwd: root, env: isolatedGitEnvironment });
return root;
function result(status, stdout = '', stderr = '') {
return {
status,
stdout: Buffer.from(stdout),
stderr: Buffer.from(stderr),
error: undefined,
};
}
async function write(root, relativePath, content = '') {
const destination = path.join(root, relativePath);
await mkdir(path.dirname(destination), { recursive: true });
await writeFile(destination, content, 'utf8');
function gitRunner(responses, calls) {
return (args, options) => {
calls.push({ args, options });
const response = responses.shift();
assert.ok(response, 'unexpected Git invocation');
return response;
};
}
test('reports a tracked file covered by a later ignore rule', async (t) => {
const root = await createRepository();
t.after(() => rm(root, { recursive: true, force: true }));
test('reports sorted tracked paths returned by check-ignore', () => {
const calls = [];
const tracked = 'server/src/storage/repository.ts\0server/src/__tests__/storage/example.test.ts\0';
const ignored =
'server/src/storage/repository.ts\0server/src/__tests__/storage/example.test.ts\0';
await write(root, 'server/src/__tests__/storage/example.test.ts', 'export {};\n');
execFileSync('git', ['add', 'server/src/__tests__/storage/example.test.ts'], {
cwd: root,
env: isolatedGitEnvironment,
assert.deepEqual(
findIgnoredTrackedFiles(
'/repo',
gitRunner([result(0, tracked), result(0, ignored)], calls)
),
['server/src/__tests__/storage/example.test.ts', 'server/src/storage/repository.ts']
);
assert.deepEqual(calls[0], {
args: ['ls-files', '-z'],
options: { cwd: '/repo' },
});
assert.deepEqual(calls[1], {
args: ['check-ignore', '--no-index', '-z', '--stdin'],
options: { cwd: '/repo', input: Buffer.from(tracked) },
});
await write(root, '.gitignore', 'storage/\n');
assert.deepEqual(findIgnoredTrackedFiles(root, isolatedGitEnvironment), [
'server/src/__tests__/storage/example.test.ts',
]);
});
test('allows tracked storage source while anchored runtime roots stay ignored', async (t) => {
const root = await createRepository();
t.after(() => rm(root, { recursive: true, force: true }));
await write(root, '.gitignore', '/storage/\n/server/storage/\n');
await write(root, 'server/src/storage/repository.ts', 'export {};\n');
await write(root, 'server/src/__tests__/storage/repository.test.ts', 'export {};\n');
execFileSync(
'git',
[
'add',
'.gitignore',
'server/src/storage/repository.ts',
'server/src/__tests__/storage/repository.test.ts',
],
{ cwd: root, env: isolatedGitEnvironment }
);
assert.deepEqual(findIgnoredTrackedFiles(root, isolatedGitEnvironment), []);
assert.equal(
execFileSync('git', ['check-ignore', 'storage/runtime.json'], {
cwd: root,
env: isolatedGitEnvironment,
encoding: 'utf8',
}),
'storage/runtime.json\n'
);
assert.equal(
execFileSync('git', ['check-ignore', 'server/storage/runtime.json'], {
cwd: root,
env: isolatedGitEnvironment,
encoding: 'utf8',
}),
'server/storage/runtime.json\n'
test('accepts the normal check-ignore no-match exit status', () => {
const calls = [];
assert.deepEqual(
findIgnoredTrackedFiles(
'/repo',
gitRunner([result(0, 'server/src/storage/repository.ts\0'), result(1)], calls)
),
[]
);
});
test('surfaces Git command failures', () => {
assert.throws(
() => findIgnoredTrackedFiles('/repo', gitRunner([result(2, '', 'bad index')], [])),
/git ls-files failed: bad index/
);
assert.throws(
() =>
findIgnoredTrackedFiles(
'/repo',
gitRunner([result(0, 'tracked\0'), result(128, '', 'bad ignore rules')], [])
),
/git check-ignore failed: bad ignore rules/
);
});