From 96f7d22974aea6602d0a149f601f4f2158a74408 Mon Sep 17 00:00:00 2001 From: abhinav7x94 Date: Sun, 16 Aug 2026 15:48:18 +0530 Subject: [PATCH] style(extension): address X import review feedback --- .../utils/twitter-import-controller.test.ts | 8 +------- .../utils/twitter-import-controller.ts | 13 +++++++------ 2 files changed, 8 insertions(+), 13 deletions(-) diff --git a/apps/browser-extension/utils/twitter-import-controller.test.ts b/apps/browser-extension/utils/twitter-import-controller.test.ts index ccd27e79..1c3e2312 100644 --- a/apps/browser-extension/utils/twitter-import-controller.test.ts +++ b/apps/browser-extension/utils/twitter-import-controller.test.ts @@ -2,13 +2,7 @@ import { describe, expect, mock, test } from "bun:test" import { createTwitterImportController } from "./twitter-import-controller" function deferred() { - let resolve!: () => void - let reject!: (error: Error) => void - const promise = new Promise((onResolve, onReject) => { - resolve = onResolve - reject = onReject - }) - return { promise, reject, resolve } + return Promise.withResolvers() } describe("Twitter import controller", () => { diff --git a/apps/browser-extension/utils/twitter-import-controller.ts b/apps/browser-extension/utils/twitter-import-controller.ts index 6aaee80c..c51263ca 100644 --- a/apps/browser-extension/utils/twitter-import-controller.ts +++ b/apps/browser-extension/utils/twitter-import-controller.ts @@ -11,12 +11,13 @@ export function createTwitterImportController( start(config: Config): Promise | null { if (running) return null - let task: Promise - try { - task = Promise.resolve(createImporter(config).startImport()) - } catch (error) { - task = Promise.reject(error) - } + const task = (() => { + try { + return Promise.resolve(createImporter(config).startImport()) + } catch (error) { + return Promise.reject(error) + } + })() running = task void task