scriptoriumadmin/supermemory
1
0
Fork 0
mirror of https://github.com/supermemoryai/supermemory.git synced 2026-10-26 06:04:08 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(tools): treat inherited names as unknown tools in the OpenAI executor

Browse source 
Names like constructor, toString and __proto__ resolved Object.prototype members as schemas and threw on parameters.required, failing the whole tool batch. The schema lookup now uses Object.hasOwn, so they return the usual unknown-function error.
This commit is contained in:
Mahesh Sanikommu 2026-10-12 16:01:33 -07:00
parent 8fdb2d4779
commit 92508cc6d0
2 changed files with 19 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/tools/src/openai/tools.ts
View file

@ -501,8 +501,10 @@ export function createToolCallExecutor(
const args = parsed.value
// Blank arguments are only valid for tools with no required fields.
const schema =
memoryToolSchemas[functionName as keyof typeof memoryToolSchemas]
// hasOwn so names like "constructor" fall through to the unknown-function error.
const schema = Object.hasOwn(memoryToolSchemas, functionName)
? memoryToolSchemas[functionName as keyof typeof memoryToolSchemas]
: undefined
const missing = schema?.parameters.required.filter(
(field: string) =>
typeof args[field] !== "string" || args[field].trim() === "",

15
packages/tools/src/tool-operations.test.ts
View file

@ -404,6 +404,21 @@ describe("openai executeToolCall argument parsing", () => {
expect(sdk.add).not.toHaveBeenCalled()
})
it.each([
"constructor",
"toString",
"__proto__",
])("reports inherited name %p as an unknown function", async (name) => {
const execute = openAi.createToolCallExecutor(API_KEY)
const result = JSON.parse(await execute(toolCall(name, "{}")))
expect(result).toEqual({
success: false,
error: `Unknown function: ${name}`,
})
})
it("still reports malformed JSON as a tool error", async () => {
const execute = openAi.createToolCallExecutor(API_KEY)