From 85ddb64bfd1f359d630fe1f6da7a908add040db2 Mon Sep 17 00:00:00 2001
From: Aditya kumar singh <143548997+Adityakk9031@users.noreply.github.com>
Date: Thu, 17 Sep 2026 17:05:29 +0530
Subject: [PATCH] fix(tools): handle trailing slashes and whitespace in
 normalizeBaseUrl and addConversation

---
 packages/tools/src/shared/context.ts    |  4 ++--
 packages/tools/src/tools-shared.test.ts | 27 +++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/packages/tools/src/shared/context.ts b/packages/tools/src/shared/context.ts
index f98bd265..8521eb5a 100644
--- a/packages/tools/src/shared/context.ts
+++ b/packages/tools/src/shared/context.ts
@@ -8,8 +8,8 @@ import { Supermemory } from "supermemory"
  */
 export const normalizeBaseUrl = (url?: string): string => {
 	const defaultUrl = "https://api.supermemory.ai"
-	if (!url) return defaultUrl
-	return url.endsWith("/") ? url.slice(0, -1) : url
+	const trimmed = url?.trim().replace(/\/+$/, "")
+	return trimmed || defaultUrl
 }
 
 /**
diff --git a/packages/tools/src/tools-shared.test.ts b/packages/tools/src/tools-shared.test.ts
index 756cec7e..f963b896 100644
--- a/packages/tools/src/tools-shared.test.ts
+++ b/packages/tools/src/tools-shared.test.ts
@@ -1,5 +1,6 @@
 import { describe, expect, it } from "vitest"
 import { makeTurnKey } from "./shared/cache"
+import { normalizeBaseUrl } from "./shared/context"
 import {
 	DEFAULT_VALUES,
 	SEARCH_LIMIT_BOUNDS,
@@ -157,3 +158,29 @@ describe("makeTurnKey", () => {
 		expect(keyA).not.toBe(keyB)
 	})
 })
+
+describe("normalizeBaseUrl", () => {
+	it("returns default URL when input is missing or empty", () => {
+		expect(normalizeBaseUrl()).toBe("https://api.supermemory.ai")
+		expect(normalizeBaseUrl("")).toBe("https://api.supermemory.ai")
+		expect(normalizeBaseUrl("   ")).toBe("https://api.supermemory.ai")
+	})
+
+	it("collapses single and multiple trailing slashes", () => {
+		expect(normalizeBaseUrl("http://localhost:6768/")).toBe(
+			"http://localhost:6768",
+		)
+		expect(normalizeBaseUrl("http://localhost:6768///")).toBe(
+			"http://localhost:6768",
+		)
+		expect(normalizeBaseUrl("https://api.supermemory.ai/")).toBe(
+			"https://api.supermemory.ai",
+		)
+	})
+
+	it("trims whitespace around URLs", () => {
+		expect(normalizeBaseUrl("  http://localhost:6768/  ")).toBe(
+			"http://localhost:6768",
+		)
+	})
+})