fix(extension): restore global save shortcut

apps/browser-extension/entrypoints/content/shared.ts

@@ -1,4 +1,5 @@
 import { MESSAGE_TYPES } from "../../utils/constants"
+import { isSaveMemoryShortcut } from "../../utils/keyboard-shortcut"
 import { bearerToken, userData } from "../../utils/storage"
 import type { APIResponse } from "../../utils/types"
 import { DOMUtils } from "../../utils/ui-components"
@@ -94,11 +95,7 @@ export async function saveMemory(
 
 export function setupGlobalKeyboardShortcut() {
 	document.addEventListener("keydown", async (event) => {
-		if (
-			(event.ctrlKey || event.metaKey) &&
-			event.shiftKey &&
-			event.key === "m"
-		) {
+		if (isSaveMemoryShortcut(event)) {
 			event.preventDefault()
 			await saveMemory("keyboard_shortcut")
 		}

apps/browser-extension/utils/keyboard-shortcut.test.ts

@@ -0,0 +1,50 @@
+import { describe, expect, it } from "bun:test"
+import {
+	isSaveMemoryShortcut,
+	type SaveMemoryShortcutEvent,
+} from "./keyboard-shortcut"
+
+function shortcutEvent(
+	overrides: Partial<SaveMemoryShortcutEvent> = {},
+): SaveMemoryShortcutEvent {
+	return {
+		ctrlKey: false,
+		key: "M",
+		metaKey: false,
+		repeat: false,
+		shiftKey: true,
+		...overrides,
+	}
+}
+
+describe("isSaveMemoryShortcut", () => {
+	it("accepts uppercase M from Ctrl+Shift+M", () => {
+		expect(isSaveMemoryShortcut(shortcutEvent({ ctrlKey: true }))).toBeTrue()
+	})
+
+	it("accepts uppercase M from Command+Shift+M", () => {
+		expect(isSaveMemoryShortcut(shortcutEvent({ metaKey: true }))).toBeTrue()
+	})
+
+	it("accepts lowercase key representations", () => {
+		expect(
+			isSaveMemoryShortcut(shortcutEvent({ ctrlKey: true, key: "m" })),
+		).toBeTrue()
+	})
+
+	it("rejects missing modifiers and other keys", () => {
+		expect(isSaveMemoryShortcut(shortcutEvent())).toBeFalse()
+		expect(
+			isSaveMemoryShortcut(shortcutEvent({ ctrlKey: true, shiftKey: false })),
+		).toBeFalse()
+		expect(
+			isSaveMemoryShortcut(shortcutEvent({ ctrlKey: true, key: "N" })),
+		).toBeFalse()
+	})
+
+	it("rejects repeated keydown events", () => {
+		expect(
+			isSaveMemoryShortcut(shortcutEvent({ ctrlKey: true, repeat: true })),
+		).toBeFalse()
+	})
+})

apps/browser-extension/utils/keyboard-shortcut.ts

@@ -0,0 +1,13 @@
+export type SaveMemoryShortcutEvent = Pick<
+	KeyboardEvent,
+	"ctrlKey" | "key" | "metaKey" | "repeat" | "shiftKey"
+>
+
+export function isSaveMemoryShortcut(event: SaveMemoryShortcutEvent): boolean {
+	return (
+		!event.repeat &&
+		(event.ctrlKey || event.metaKey) &&
+		event.shiftKey &&
+		event.key.toLowerCase() === "m"
+	)
+}