scriptoriumadmin/supermemory
1
0
Fork 0
mirror of https://github.com/supermemoryai/supermemory.git synced 2026-09-15 23:31:05 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Perf: gate onViewportChange behind popover-visible check

Browse source 
Only fire onViewportChange (which triggers React state update +
reconciliation) when a popover is actually visible (selectedNodeId
or hoveredNodeId is set). This avoids forcing 60fps React re-renders
during plain panning/zooming when no popover needs repositioning.

Also separate prevVp* tracking from the callback gate so viewport
state is always current when a node is first hovered/selected.
This commit is contained in:
Vorflux AI 2026-03-27 18:34:24 +00:00
parent 8dced3d5ed
commit 52c0a615c1
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
packages/memory-graph/src/components/graph-canvas.tsx
View file

@ -234,12 +234,19 @@ export const GraphCanvas = memo<ExtendedGraphCanvasProps>(function GraphCanvas({
return
renderNeeded.current = false
// Report viewport changes (zoom, pan, or simulation-driven node movement)
// so popover positions update. Covers: momentum, spring zoom, mouse drag, and sim.
// Report viewport changes so popover positions update.
// Only fire when a popover is actually visible (selected or hovered node)
// to avoid triggering React re-renders at 60fps during plain panning.
const vpChanged =
vp.panX !== prevVpX || vp.panY !== prevVpY || vp.zoom !== prevVpZoom
if ((vpChanged || simActive) && cb.current.onViewportChange) {
if (
(vpChanged || simActive) &&
(cur.selectedNodeId || cur.hoveredNodeId) &&
cb.current.onViewportChange
) {
cb.current.onViewportChange(vp.zoom)
}
if (vpChanged) {
prevVpX = vp.panX
prevVpY = vp.panY
prevVpZoom = vp.zoom