scriptoriumadmin/supermemory
1
0
Fork 0
mirror of https://github.com/supermemoryai/supermemory.git synced 2026-09-12 23:01:07 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: move version chain rebuild from useEffect to render path

Browse source 
The chainIndex.rebuild() was called in a useEffect (runs after render),
but getChain() was called in a useMemo (runs during render). This meant
getChain() could read stale data from the old chain index when
limitedDocuments changed.

Moving rebuild() inline (during render) ensures the chain index is
always up-to-date before getChain() is called. The rebuild() method
has a referential equality guard that makes it a no-op on re-renders
where limitedDocuments hasn't changed.
This commit is contained in:
Vorflux AI 2026-03-29 01:12:22 +00:00
parent b08760ef85
commit 44ab6a5fc6
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/memory-graph/src/components/memory-graph.tsx
View file

@ -79,10 +79,11 @@ export function MemoryGraph({
colors,
)
// Rebuild version chain index when documents change
useEffect(() => {
chainIndex.current.rebuild(limitedDocuments)
}, [limitedDocuments])
// Rebuild version chain index during render (not in an effect) so that
// the chain data is up-to-date when getChain() is called in useMemo below.
// rebuild() has an early-return guard (referential equality on documents)
// that makes this a no-op on re-renders where limitedDocuments hasn't changed.
chainIndex.current.rebuild(limitedDocuments)
// Smart simulation re-init: track node ID set, only init() when IDs change
const prevSimIdsRef = useRef<string>("")
@ -494,6 +495,7 @@ export function MemoryGraph({
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [activeNodeData, viewportVersion])
// biome-ignore lint/correctness/useExhaustiveDependencies: limitedDocuments triggers re-computation after chainIndex.current.rebuild() runs with new data
const activeVersionChain = useMemo(() => {
if (!activeNodeData || activeNodeData.type !== "memory") return null
return chainIndex.current.getChain(activeNodeData.id)