From 1c80d43235d8a31e20c3f2b50e0baa9aa4ef6866 Mon Sep 17 00:00:00 2001 From: MaheshtheDev <38828053+MaheshtheDev@users.noreply.github.com> Date: Tue, 28 Apr 2026 23:46:56 +0000 Subject: [PATCH] fix: better-auth better error catch (#892) --- apps/web/app/(auth)/login/new/page.tsx | 30 +++++++++++++++----------- packages/lib/auth.ts | 1 - 2 files changed, 18 insertions(+), 13 deletions(-) diff --git a/apps/web/app/(auth)/login/new/page.tsx b/apps/web/app/(auth)/login/new/page.tsx index e3d2a1c5..421d0f06 100644 --- a/apps/web/app/(auth)/login/new/page.tsx +++ b/apps/web/app/(auth)/login/new/page.tsx @@ -204,18 +204,12 @@ export default function LoginPage() { email_domain: email.split("@")[1] || "unknown", }) - try { - await signIn.magicLink({ - callbackURL: getCallbackURL(), - email, - }) - setSubmittedEmail(email) - setPendingLoginMethod("magic_link") - // Track successful magic link send - posthog.capture("login_magic_link_sent", { - email_domain: email.split("@")[1] || "unknown", - }) - } catch (error) { + const { error } = await signIn.magicLink({ + callbackURL: getCallbackURL(), + email, + }) + + if (error) { console.error(error) // Track login failure @@ -232,6 +226,12 @@ export default function LoginPage() { return } + setSubmittedEmail(email) + setPendingLoginMethod("magic_link") + posthog.capture("login_magic_link_sent", { + email_domain: email.split("@")[1] || "unknown", + }) + setIsLoading(false) setIsLoadingEmail(false) } @@ -355,6 +355,9 @@ export default function LoginPage() { callbackURL: getCallbackURL(), provider: "google", }) + .catch((err: unknown) => { + setError(getErrorMessage(err)) + }) .finally(() => { setIsLoading(false) }) @@ -419,6 +422,9 @@ export default function LoginPage() { callbackURL: getCallbackURL(), provider: "github", }) + .catch((err: unknown) => { + setError(getErrorMessage(err)) + }) .finally(() => { setIsLoading(false) }) diff --git a/packages/lib/auth.ts b/packages/lib/auth.ts index 4369bef1..081c1053 100644 --- a/packages/lib/auth.ts +++ b/packages/lib/auth.ts @@ -13,7 +13,6 @@ export const authClient = createAuthClient({ baseURL: process.env.NEXT_PUBLIC_BACKEND_URL ?? "https://api.supermemory.ai", fetchOptions: { credentials: "include", - throw: true, }, plugins: [ usernameClient(),