diff --git a/apps/mcp/src/server/client/index.test.ts b/apps/mcp/src/server/client/index.test.ts new file mode 100644 index 00000000..68ea5703 --- /dev/null +++ b/apps/mcp/src/server/client/index.test.ts @@ -0,0 +1,66 @@ +import { afterEach, describe, expect, it, vi } from "vitest" +import { SupermemoryClient } from "./index" + +const API_URL = "https://api.example.com" + +describe("SupermemoryClient.getDocuments", () => { + afterEach(() => { + vi.restoreAllMocks() + vi.unstubAllGlobals() + }) + + function stubFetch() { + const fetchMock = vi.fn().mockResolvedValue( + Response.json({ + documents: [], + pagination: { + currentPage: 1, + limit: 200, + totalItems: 0, + totalPages: 0, + }, + }), + ) + vi.stubGlobal("fetch", fetchMock) + return fetchMock + } + + it("cancels through a caller-provided signal", async () => { + const fetchMock = stubFetch() + const controller = new AbortController() + + await new SupermemoryClient("sm_test_key", "user_1", API_URL).getDocuments( + ["user_1"], + 1, + 200, + { signal: controller.signal }, + ) + + const [, init] = fetchMock.mock.calls[0] as [string, RequestInit] + controller.abort() + expect(init.signal?.aborted).toBe(true) + }) + + it("keeps the timeout when a caller-provided signal is present", async () => { + const timeoutController = new AbortController() + const timeoutSpy = vi + .spyOn(AbortSignal, "timeout") + .mockReturnValue(timeoutController.signal) + const fetchMock = stubFetch() + + await new SupermemoryClient("sm_test_key", "user_1", API_URL).getDocuments( + ["user_1"], + 1, + 200, + { signal: new AbortController().signal }, + ) + + expect(timeoutSpy).toHaveBeenCalledWith(30_000) + + const [, init] = fetchMock.mock.calls[0] as [string, RequestInit] + // Firing only the timeout leg aborts the request: a caller signal adds + // cancellation, it does not remove the 30s bound. + timeoutController.abort() + expect(init.signal?.aborted).toBe(true) + }) +}) diff --git a/apps/mcp/src/server/client/index.ts b/apps/mcp/src/server/client/index.ts index a2ccc8e7..f25f014a 100644 --- a/apps/mcp/src/server/client/index.ts +++ b/apps/mcp/src/server/client/index.ts @@ -336,7 +336,14 @@ export class SupermemoryClient { options?: { signal?: AbortSignal }, ): Promise { try { - const signal = options?.signal ?? AbortSignal.timeout(FETCH_TIMEOUT_MS) + // Compose rather than choose: a caller-supplied signal must add + // cancellation on top of the timeout, not replace it. + const signal = options?.signal + ? AbortSignal.any([ + options.signal, + AbortSignal.timeout(FETCH_TIMEOUT_MS), + ]) + : AbortSignal.timeout(FETCH_TIMEOUT_MS) const response = await fetch(`${this.apiUrl}/v3/documents/documents`, { method: "POST", headers: {