From 00c02db17686f6b5eb53c692cdbaa5c25cdd212d Mon Sep 17 00:00:00 2001 From: harshitgavita-07 Date: Fri, 2 Oct 2026 23:55:19 +0530 Subject: [PATCH] test(agent-framework): add_memory must not reuse the conversation document id Add tests to ensure unique document IDs for memory entries. --- .../tests/test_tools.py | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/packages/agent-framework-python/tests/test_tools.py b/packages/agent-framework-python/tests/test_tools.py index 00da0f7d..17fdb080 100644 --- a/packages/agent-framework-python/tests/test_tools.py +++ b/packages/agent-framework-python/tests/test_tools.py @@ -47,3 +47,31 @@ class TestSupermemoryTools: conn = _make_conn(conversation_id="conv-123") tools = SupermemoryTools(conn) assert tools._connection.custom_id == "conversation_conv-123" + + +class _RecordingClient: + def __init__(self) -> None: + self.add_calls: list[dict] = [] + + async def add(self, **kwargs): + self.add_calls.append(kwargs) + return {"id": f"doc-{len(self.add_calls)}", "status": "queued"} + + +class TestAddMemoryDocumentIdentity: + @pytest.mark.asyncio + async def test_add_memory_does_not_reuse_conversation_document_id(self) -> None: + conn = _make_conn(conversation_id="conv-123") + tools = SupermemoryTools(conn) + client = _RecordingClient() + tools._client = client + + await tools.add_memory("The user likes green tea.") + await tools.add_memory("The user lives in Lisbon.") + + assert len(client.add_calls) == 2 + # A shared custom_id makes Supermemory treat every call as an update of one + # document, so the second memory replaces the first and both collide with the + # conversation transcript saved under the same id. + assert all(call.get("custom_id") != conn.custom_id for call in client.add_calls) + assert all(call["container_tag"] == "msft_agent_chat" for call in client.add_calls)