mirror of
https://github.com/usestrix/strix.git
synced 2026-10-11 03:37:54 +00:00
16a316540c
Plain text is now the only channel to the user. wait_for_user takes no arguments and only parks the agent, so a reply can no longer be written twice (once as text, once as a tool argument). The driver bounces a wait_for_user call that follows no assistant text back into recovery. TUI and viewer render wait_for_user as the waiting marker alone and keep rendering recorded respond_to_user events with their message.
45 lines
1.8 KiB
Python
45 lines
1.8 KiB
Python
"""Every parameter of every scan-agent tool carries a description in its JSON schema.
|
|
|
|
The model only sees a parameter's docstring text through the schema. An ``Args:``
|
|
section that the docstring parser fails to recognise (for example because an
|
|
earlier line opens a markdown code fence it never closes) silently drops every
|
|
parameter description, so optional-but-conditionally-required fields such as
|
|
``confidence_rationale`` become anonymous nullable strings the model never fills.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import pytest
|
|
from agents.tool import FunctionTool
|
|
|
|
from strix.agents import factory
|
|
from strix.tools.agents_graph.tools import agent_finish
|
|
from strix.tools.finish.tool import finish_scan
|
|
from strix.tools.reporting.tool import create_vulnerability_report
|
|
from strix.tools.wait_for_user.tool import wait_for_user
|
|
|
|
|
|
_SCAN_AGENT_TOOLS = [
|
|
tool
|
|
for tool in (*factory._BASE_TOOLS, finish_scan, agent_finish, wait_for_user)
|
|
if isinstance(tool, FunctionTool)
|
|
]
|
|
|
|
|
|
@pytest.mark.parametrize("tool", _SCAN_AGENT_TOOLS, ids=lambda tool: tool.name)
|
|
def test_every_parameter_has_a_description(tool: FunctionTool) -> None:
|
|
properties = tool.params_json_schema.get("properties", {})
|
|
missing = sorted(
|
|
name
|
|
for name, schema in properties.items()
|
|
if not (isinstance(schema.get("description"), str) and schema["description"].strip())
|
|
)
|
|
assert not missing, f"{tool.name}: parameters without a description: {missing}"
|
|
|
|
|
|
def test_create_vulnerability_report_explains_confidence_rationale() -> None:
|
|
schema = create_vulnerability_report.params_json_schema["properties"]
|
|
assert "confidence" in create_vulnerability_report.params_json_schema["required"]
|
|
rationale = schema["confidence_rationale"]["description"]
|
|
assert "Required when" in rationale
|
|
assert "high" in rationale
|