strix/tests
0xallam 572ef2a2af fix: address audit findings — SDK plumbing, TUI bus, dead code
Critical fixes:

- ``StrixOrchestrationHooks.on_agent_start`` now finds the
  ``CaidoCapability`` via ``ctx.context['caido_capability']`` instead
  of ``agent.capabilities`` (we use plain ``Agent``, not
  ``SandboxAgent``, so the latter never existed). The session
  manager's bundle already exposes the capability; ``run_strix_scan``
  threads it through ``make_agent_context`` and ``create_agent``
  forwards it to children.

- ``run_strix_scan`` registers the ``StrixTracingProcessor`` with the
  SDK's tracing provider via ``add_trace_processor`` so SDK trace
  spans hit ``run_dir/events.jsonl`` (was previously a parallel stream
  the SDK ignored).

- ``on_llm_end`` now writes to ``Tracer.record_llm_usage`` in
  addition to ``bus.record_usage`` so the CLI/TUI stats panel sees
  real numbers instead of zeros.

- ``run_strix_scan`` accepts an externally-built ``AgentMessageBus``
  + an explicit ``model`` arg. The TUI pre-creates the bus so its
  stop and chat-input handlers can submit ``bus.send`` /
  ``bus.cancel_descendants`` coroutines onto the scan thread's loop
  via ``asyncio.run_coroutine_threadsafe`` — replacing the
  TODO-stub no-ops.

- ``model`` config now propagates root → context → child agents in
  ``create_agent`` (was hardcoded fallback).

Dead-code removal:

- Deleted the ``load_skill`` tool entirely (host module, sandbox
  module, TUI renderer, tests). The legacy implementation reached
  into a global ``_agent_instances`` registry that no longer exists;
  the post-migration stub returned ``success=True`` without
  injecting anything — pure theater. Skills are still preloaded via
  the system prompt at scan-bring-up.

- Dropped ``tenacity`` and ``xmltodict`` from
  ``[project.dependencies]`` — neither is imported anywhere
  post-migration.

- Stripped the system prompt's "use the load_skill tool" lines.

Tests: 278/278 passing. Removed two ``load_skill`` test cases and a
``test_tool_registration_modes::test_load_skill_import_...`` assertion
that exercised the deleted module.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-25 10:08:35 -07:00
..
agents fix: address audit findings — SDK plumbing, TUI bus, dead code 2026-04-25 10:08:35 -07:00
config fix: --config flag now fully overrides ~/.strix/cli-config.json (#457) 2026-04-22 16:37:22 -04:00
interface refactor: nuke legacy harness, drop sdk_ prefixes 2026-04-25 09:30:23 -07:00
llm refactor: remove all strix/ model alias machinery 2026-04-25 09:37:14 -07:00
orchestration feat(migration): phase 0 — foundation files + smoke tests for SDK migration 2026-04-24 23:43:56 -07:00
runtime feat(migration): phase 0 — foundation files + smoke tests for SDK migration 2026-04-24 23:43:56 -07:00
sandbox feat(migration): phase 4 — sandbox capability + healthcheck + session manager 2026-04-25 00:49:26 -07:00
skills feat: add skills for specific tools (#366) 2026-03-19 16:47:29 -07:00
static feat(migration): phase 0 — foundation files + smoke tests for SDK migration 2026-04-24 23:43:56 -07:00
telemetry refactor: nuke legacy harness, drop sdk_ prefixes 2026-04-25 09:30:23 -07:00
tools fix: address audit findings — SDK plumbing, TUI bus, dead code 2026-04-25 10:08:35 -07:00
__init__.py test: add initial unit tests for argument_parser module 2025-12-04 00:02:14 +04:00
conftest.py refactor(tests): reorganize unit tests module structure 2025-12-04 00:02:14 +04:00
test_entry.py refactor: nuke legacy harness, drop sdk_ prefixes 2026-04-25 09:30:23 -07:00
test_run_config_factory.py refactor: remove all strix/ model alias machinery 2026-04-25 09:37:14 -07:00