mirror of
https://github.com/usestrix/strix.git
synced 2026-10-11 03:37:54 +00:00
121216096c
Replaces the pattern-matched urllib3/http.client filter with a generic rule: sys.unraisablehook (finalizers, __del__, GC and weakref callbacks, files closed at exit) and threading.excepthook are replaced for the life of the process with hooks that log the report at WARNING on strix.telemetry. That goes to strix.log, and to stderr only when the stream handler runs at DEBUG (STRIX_DEBUG=1). Nothing is delegated to Python's default printers; a report arriving after the strix handlers are torn down is dropped instead of reaching logging.lastResort, and failures inside logging itself are swallowed so nothing can print mid-shutdown. tests/test_hook_exceptions_logged.py covers both hooks in-process and end to end in a fresh interpreter (a __del__ raising at shutdown, a thread traceback, a urllib3 response whose file was closed first): stderr stays empty.
112 lines
3.8 KiB
Python
112 lines
3.8 KiB
Python
import http.client
|
|
import http.cookiejar
|
|
import socket
|
|
import sys
|
|
|
|
import pytest
|
|
import urllib3.response
|
|
|
|
from strix.telemetry import logging as tlog
|
|
from strix.telemetry.logging import _is_urllib3_closed_file_noise
|
|
|
|
|
|
class _Args:
|
|
def __init__(
|
|
self, exc_value: BaseException | None, obj: object, err_msg: str | None = None
|
|
) -> None:
|
|
self.exc_type = type(exc_value) if exc_value is not None else None
|
|
self.exc_value = exc_value
|
|
self.exc_traceback = None
|
|
self.err_msg = err_msg
|
|
self.object = obj
|
|
|
|
|
|
def _urllib3_response() -> urllib3.response.HTTPResponse:
|
|
return urllib3.response.HTTPResponse(body=b"")
|
|
|
|
|
|
def test_filters_urllib3_closed_file_noise() -> None:
|
|
args = _Args(ValueError("I/O operation on closed file."), _urllib3_response())
|
|
assert _is_urllib3_closed_file_noise(args) # type: ignore[arg-type]
|
|
|
|
|
|
def test_ignores_closed_file_errors_from_other_http_modules() -> None:
|
|
args = _Args(ValueError("I/O operation on closed file."), http.cookiejar.CookieJar())
|
|
assert not _is_urllib3_closed_file_noise(args) # type: ignore[arg-type]
|
|
|
|
|
|
def test_filters_http_client_closed_file_noise() -> None:
|
|
sock = socket.socket()
|
|
try:
|
|
response = http.client.HTTPResponse(sock)
|
|
finally:
|
|
sock.close()
|
|
args = _Args(ValueError("I/O operation on closed file."), response)
|
|
assert _is_urllib3_closed_file_noise(args) # type: ignore[arg-type]
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"repr_text",
|
|
[
|
|
"<urllib3.response.HTTPResponse object at 0x7f2d3c1f0b10>",
|
|
"<http.client.HTTPResponse object at 0x7f2d3c1f0b10>",
|
|
],
|
|
)
|
|
def test_filters_python314_finalizer_shape(repr_text: str) -> None:
|
|
"""3.14 reports IOBase finalizer failures with object=None and the repr in err_msg."""
|
|
args = _Args(
|
|
ValueError("I/O operation on closed file."),
|
|
None,
|
|
err_msg=f"Exception ignored while finalizing file {repr_text}",
|
|
)
|
|
assert _is_urllib3_closed_file_noise(args) # type: ignore[arg-type]
|
|
|
|
|
|
def test_python314_shape_passes_through_other_files() -> None:
|
|
args = _Args(
|
|
ValueError("I/O operation on closed file."),
|
|
None,
|
|
err_msg="Exception ignored while finalizing file <_io.TextIOWrapper name='x' mode='w'>",
|
|
)
|
|
assert not _is_urllib3_closed_file_noise(args) # type: ignore[arg-type]
|
|
assert not _is_urllib3_closed_file_noise(
|
|
_Args(ValueError("I/O operation on closed file."), None) # type: ignore[arg-type]
|
|
)
|
|
|
|
|
|
def test_passes_through_other_unraisables() -> None:
|
|
assert not _is_urllib3_closed_file_noise(
|
|
_Args(ValueError("I/O operation on closed file."), object()) # type: ignore[arg-type]
|
|
)
|
|
assert not _is_urllib3_closed_file_noise(
|
|
_Args(RuntimeError("boom"), _urllib3_response()) # type: ignore[arg-type]
|
|
)
|
|
assert not _is_urllib3_closed_file_noise(
|
|
_Args(ValueError("something else"), _urllib3_response()) # type: ignore[arg-type]
|
|
)
|
|
|
|
|
|
def test_installed_hook_filters_and_delegates(monkeypatch: pytest.MonkeyPatch) -> None:
|
|
calls: list[object] = []
|
|
monkeypatch.setattr(sys, "unraisablehook", calls.append)
|
|
monkeypatch.setattr(tlog, "_unraisable_hook_installed", False)
|
|
tlog._silence_urllib3_finalizer_noise()
|
|
hook = sys.unraisablehook
|
|
assert hook is not calls.append
|
|
|
|
hook(_Args(ValueError("I/O operation on closed file."), _urllib3_response())) # type: ignore[arg-type]
|
|
hook(
|
|
_Args( # type: ignore[arg-type]
|
|
ValueError("I/O operation on closed file."),
|
|
None,
|
|
err_msg=(
|
|
"Exception ignored while finalizing file "
|
|
"<urllib3.response.HTTPResponse object at 0x1>"
|
|
),
|
|
)
|
|
)
|
|
assert calls == []
|
|
|
|
other = _Args(RuntimeError("boom"), object())
|
|
hook(other) # type: ignore[arg-type]
|
|
assert calls == [other]
|