From f91c9ef62ee717ca8764f0e369d74515542ee8fc Mon Sep 17 00:00:00 2001 From: STJ Date: Fri, 13 Mar 2026 17:07:14 -0700 Subject: [PATCH] important notes --- strix/tools/browser/browser_manager.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/strix/tools/browser/browser_manager.py b/strix/tools/browser/browser_manager.py index b1297b55..d3dfb009 100644 --- a/strix/tools/browser/browser_manager.py +++ b/strix/tools/browser/browser_manager.py @@ -146,7 +146,12 @@ async def _wait_for_cdp( raise _CDPNotReadyError(f"HTTP {resp.status_code}") info = resp.json() + + # [info] convert http://localhost:9117 or whatever to this format: + # > ws://localhost:9117/browser/proxy/?token= + # for the debugger url to work (since its randomly generated) ws_url = _rewrite_ws_url(cdp_url, info.get("webSocketDebuggerUrl", ""), auth_token) + logger.info("CDP ready: %s", info.get("Browser", "?")) return ws_url, info @@ -172,6 +177,7 @@ async def _launch_browser(cdp_url: str, agent_id: str, auth_token: str = "") -> browser = Browser(cdp_url=ws_url) if session := _manager.get(agent_id): + # [lint] ruff requires us to store background future tasks task = asyncio.ensure_future(_close_browser(browser)) _manager.background_tasks.add(task) task.add_done_callback(_manager.background_tasks.discard)