From 85e1e1b6f28cb93d583078fad26807a2cee9d9f9 Mon Sep 17 00:00:00 2001 From: Samy6767f Date: Mon, 24 Aug 2026 18:48:32 +0530 Subject: [PATCH] fix(interface): prevent path traversal and argument injection in clone_repository - Replace unsafe Path().stem/name derivation with derive_repo_base_name() which strips .git suffix and sanitizes via regex, preventing '..git' from resolving to '..' and causing rmtree to delete parent directories. - Add resolved-path containment check: clone_path.resolve() must start with temp_dir.resolve(), rejecting any traversal attempt. - Insert '--' end-of-options separator before repo_url in the git clone subprocess call, preventing targets starting with '-' from being interpreted as git flags (e.g. --upload-pack for RCE). - Add explicit validation rejecting repo_url starting with '-' with a clear error message before any subprocess invocation. Fixes #1133, fixes #1134. --- strix/interface/utils.py | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/strix/interface/utils.py b/strix/interface/utils.py index faab1772..8a80942b 100644 --- a/strix/interface/utils.py +++ b/strix/interface/utils.py @@ -1563,19 +1563,34 @@ def clone_repository(repo_url: str, run_name: str, dest_name: str | None = None) if dest_name: repo_name = dest_name else: - repo_name = Path(repo_url).stem if repo_url.endswith(".git") else Path(repo_url).name + repo_name = derive_repo_base_name(repo_url) - clone_path = temp_dir / repo_name + # Guard against path traversal: the derived name must not resolve + # outside the temp directory (e.g. ".." or "."). + clone_path = (temp_dir / repo_name).resolve() + if not str(clone_path).startswith(str(temp_dir.resolve())): + raise ValueError( + f"Refusing to clone: derived directory name '{repo_name}' " + f"escapes the temporary directory" + ) if clone_path.exists(): shutil.rmtree(clone_path) try: + # Reject targets that start with '-' to block argument injection + if repo_url.startswith("-"): + raise ValueError( + f"Refusing to clone: target '{repo_url}' starts with '-' " + f"and would be interpreted as a git flag" + ) + with console.status(f"[bold cyan]Cloning repository {repo_url}...", spinner="dots"): subprocess.run( # noqa: S603 [ git_executable, "clone", + "--", # end-of-options: everything after is a positional arg repo_url, str(clone_path), ],