scriptoriumadmin/strix
1
0
Fork 0
mirror of https://github.com/usestrix/strix.git synced 2026-10-02 02:13:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(tui): use native clipboard tools so copy works in macOS Terminal

Browse source 
Textual's copy_to_clipboard uses OSC 52, which Terminal.app does not
honor by default, so the Copy button silently did nothing. Add a
_native_clipboard_copy helper that shells out to pbcopy on macOS, clip
on Windows, and wl-copy/xclip/xsel on Linux, then falls back to OSC 52.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
h0tak88r 2026-06-03 19:48:16 +03:00
parent 3bd9d56814
commit 6e17cfb9b9
1 changed files with 35 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
strix/interface/tui/app.py
View file

@ -3,7 +3,9 @@ import asyncio
import atexit
import contextlib
import logging
import platform
import signal
import subprocess
import sys
import threading
from collections.abc import Callable
@ -45,6 +47,32 @@ from strix.runtime import session_manager
logger = logging.getLogger(__name__)
def _native_clipboard_copy(text: str) -> bool:
system = platform.system()
if system == "Darwin":
cmd = ["pbcopy"]
elif system == "Windows":
cmd = ["clip"]
else:
import shutil as _shutil
if _shutil.which("wl-copy"):
cmd = ["wl-copy"]
elif _shutil.which("xclip"):
cmd = ["xclip", "-selection", "clipboard"]
elif _shutil.which("xsel"):
cmd = ["xsel", "--clipboard", "--input"]
else:
return False
try:
proc = subprocess.run(
cmd, input=text.encode("utf-8"), check=False, timeout=2
)
return proc.returncode == 0
except (OSError, subprocess.TimeoutExpired):
return False
def get_package_version() -> str:
try:
return pkg_version("strix-agent")
@ -562,7 +590,8 @@ class VulnerabilityDetailScreen(ModalScreen): # type: ignore[misc]
def on_button_pressed(self, event: Button.Pressed) -> None:
if event.button.id == "copy_vuln_detail":
markdown_text = self._get_markdown_report()
self.app.copy_to_clipboard(markdown_text)
if not _native_clipboard_copy(markdown_text):
self.app.copy_to_clipboard(markdown_text)
copy_button = self.query_one("#copy_vuln_detail", Button)
copy_button.label = "Copied!"
@ -1815,7 +1844,9 @@ class StrixTUIApp(App): # type: ignore[misc]
self.screen.clear_selection()
if selected and selected.strip():
cleaned = self._clean_copied_text(selected)
self.copy_to_clipboard(cleaned if cleaned.strip() else selected)
final_text = cleaned if cleaned.strip() else selected
if not _native_clipboard_copy(final_text):
self.copy_to_clipboard(final_text)
copied = True
except Exception:
logger.debug("Failed to copy screen selection", exc_info=True)
@ -1825,7 +1856,8 @@ class StrixTUIApp(App): # type: ignore[misc]
chat_input = self.query_one("#chat_input", ChatTextArea)
selected = chat_input.selected_text
if selected and selected.strip():
self.copy_to_clipboard(selected)
if not _native_clipboard_copy(selected):
self.copy_to_clipboard(selected)
chat_input.move_cursor(chat_input.cursor_location)
copied = True
except Exception: