scriptoriumadmin/strix
1
0
Fork 0
mirror of https://github.com/usestrix/strix.git synced 2026-10-04 02:33:47 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(tui): link every wrapped line of the viewer URL to the full URL

Browse source 
The sidebar wraps the viewer URL, and terminals that linkify by text only
pick up the first line, so the click opened the viewer with a truncated
token. Emit each wrapped line as an OSC 8 hyperlink to the whole URL.
This commit is contained in:
Ahmed Allam 2026-10-03 20:12:09 +00:00 • committed by Ahmed Allam
parent 0107a15295
commit 65172fecd8
2 changed files with 21 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
strix/interface/tui/internal/app/model_test.go
View file

@ -890,6 +890,14 @@ func TestRunningViewerShowsCompleteWrappedURL(t *testing.T) {
if want := strings.Count(model.viewerView(model.viewerContentWidth()), "\n") + 3; model.viewerHeight() != want {
t.Fatalf("viewer height = %d, want %d", model.viewerHeight(), want)
}
raw := model.viewerView(18)
if got, want := strings.Count(raw, ansi.SetHyperlink(url)), len(urlLines); got != want {
t.Fatalf("every wrapped line should link to the full URL: got %d links for %d lines in %q", got, want, raw)
}
if got := strings.Count(raw, ansi.ResetHyperlink()); got != len(urlLines) {
t.Fatalf("hyperlinks not closed: %d resets for %d lines", got, len(urlLines))
}
}
func TestVerticalScrollbarThumbTracksScrollOffset(t *testing.T) {

15
strix/interface/tui/internal/app/view.go
View file

@ -177,6 +177,18 @@ func wrapBlock(value string, width int) string {
return strings.Join(out, "\n")
}
// hyperlinkBlock wraps a URL to the column width and marks every wrapped line
// as an OSC 8 hyperlink to the whole URL. Terminals that linkify by text only
// see the first line of a wrapped URL, which for the viewer meant opening it
// with a truncated token.
func hyperlinkBlock(url string, width int, style lipgloss.Style) string {
lines := strings.Split(wrapBlock(url, width), "\n")
for i, line := range lines {
lines[i] = ansi.SetHyperlink(url) + style.Render(line) + ansi.ResetHyperlink()
}
return strings.Join(lines, "\n")
}
// scrollbarThumb brightens the bar being dragged so the grab reads as taking
// hold of it.
func (m Model) scrollbarThumb(target scrollbarTarget) lipgloss.Color {
@ -603,8 +615,7 @@ func (m Model) viewerView(width int) string {
case "running":
status := lipgloss.NewStyle().Foreground(green).Render("● Viewer running")
if m.snapshot.ViewerURL != nil && strings.TrimSpace(*m.snapshot.ViewerURL) != "" {
url := wrapBlock(strings.TrimSpace(*m.snapshot.ViewerURL), width)
return status + "\n" + lipgloss.NewStyle().Foreground(dim).Render(url)
return status + "\n" + hyperlinkBlock(strings.TrimSpace(*m.snapshot.ViewerURL), width, lipgloss.NewStyle().Foreground(dim))
}
return status
case "unavailable":