scriptoriumadmin/strix
1
0
Fork 0
mirror of https://github.com/usestrix/strix.git synced 2026-10-16 04:28:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix duplicate session history on failed-run recovery (fixes #1310)

Browse source 
_salvage_stream_to_session previously did pre_run_items + replay, which
duplicated items when stream.to_input_list() already included the
pre-cycle input (the seeded initial_input is in both). Detect the overlap
and avoid duplication by checking if replay suffix matches pre_run_items.
This commit is contained in:
dajiaohuang 2026-10-07 14:48:02 +08:00
parent f1386cad37
commit 29eaa86cda
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
strix/core/execution.py
View file

@ -156,7 +156,14 @@ async def _salvage_stream_to_session(
stream: Any,
agent_id: str,
) -> None:
"""Persist a crashed run's full history so a revived agent loses no context."""
"""Persist a crashed run's history so a revived agent loses no context.
``stream.to_input_list()`` reconstructs the conversation from this run cycle
as ``original_input + new_items``. After ``seed_initial_input``, the session
(pre_run_items) already contains the initial input on the first cycle, so
blindly concatenating duplicates it. We detect the overlap and append only
the delta.
"""
if stream is None:
return
try:
@ -164,8 +171,12 @@ async def _salvage_stream_to_session(
except Exception:
logger.exception("could not build salvage history for %s", agent_id)
return
desired = list(pre_run_items) + replay
if len(desired) <= len(pre_run_items):
pre_len = len(pre_run_items)
if pre_len > 0 and len(replay) >= pre_len and replay[-pre_len:] == pre_run_items:
desired = replay
else:
desired = list(pre_run_items) + replay
if len(desired) <= pre_len:
return
try:
await replace_session_items(session, desired)