diff --git a/strix/report/coverage.py b/strix/report/coverage.py index 76387e61..9f784391 100644 --- a/strix/report/coverage.py +++ b/strix/report/coverage.py @@ -109,7 +109,7 @@ _SKILL_PHRASINGS: dict[str, tuple[str, ...]] = { "data exposure", ), "insecure_deserialization": ("deserialization",), - "insecure_file_uploads": ("file upload",), + "insecure_file_uploads": ("file upload", "file uploads"), "llm_prompt_injection": ("prompt injection",), "mass_assignment": ("mass assignment", "parameter binding"), "nosql_injection": ("nosql",), diff --git a/tests/test_report_coverage.py b/tests/test_report_coverage.py index 76200edf..bbd53612 100644 --- a/tests/test_report_coverage.py +++ b/tests/test_report_coverage.py @@ -100,6 +100,15 @@ def test_synonym_phrasing_counts_as_recorded_coverage() -> None: assert not [gap for gap in doc["gaps"] if gap["kind"] == "unrecorded_risk_class"] +def test_plural_risk_phrase_counts_as_recorded_coverage() -> None: + doc = _document( + entries=[_entry(risk_area="File uploads")], + agent_graph=_graph(metadata={"agent-1": {"skills": ["insecure_file_uploads"]}}), + ) + + assert not [gap for gap in doc["gaps"] if gap["kind"] == "unrecorded_risk_class"] + + def test_non_risk_skills_carry_no_coverage_obligation() -> None: """Tooling skills describe how an agent works, not what it hunts.""" doc = _document(agent_graph=_graph(metadata={"agent-1": {"skills": ["idor", "caido"]}})) @@ -154,6 +163,16 @@ def test_unfinished_agent_makes_the_record_partial() -> None: assert "authz-tester" in doc["completeness"]["caveats"][0] +def test_failed_agent_makes_the_record_partial() -> None: + doc = _document( + agent_graph=_graph(statuses={"agent-1": "failed"}), + exit_reason="finished_by_tool", + ) + + assert doc["completeness"]["complete"] is False + assert "authz-tester" in doc["completeness"]["caveats"][0] + + def test_failed_run_status_makes_the_record_partial() -> None: doc = _document( run_record={"run_id": "r1", "status": "failed"},