scriptoriumadmin/strix
1
0
Fork 0
mirror of https://github.com/usestrix/strix.git synced 2026-10-02 02:13:43 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Keep an approved fix when only the PR text changes

Browse source
This commit is contained in:
yoni 2026-09-30 08:24:08 +00:00
parent ba6bbaf9c6
commit 17894006b4
2 changed files with 26 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
strix/tools/reporting/tool.py
View file

@ -446,7 +446,6 @@ _FIX_CANDIDATE_FIELDS = frozenset(
"poc_description",
"evidence",
"fix_verification",
"fix_pr_body",
"fix_candidate_blocker",
}
)

28
tests/test_reporting_fields.py
View file

@ -1124,7 +1124,7 @@ def test_vuln_tool_exposes_new_params() -> None:
assert "advisory_cvss" in dep_required
_FIX_LOCATION = {
_FIX_LOCATION: dict[str, Any] = {
"file": "app/views.py",
"start_line": 10,
"end_line": 12,
@ -1132,7 +1132,7 @@ _FIX_LOCATION = {
"fix_after": 'query = "SELECT * FROM t WHERE id=%s"',
}
_INFO_LOCATION = {
_INFO_LOCATION: dict[str, Any] = {
"file": "app/views.py",
"start_line": 10,
"end_line": 12,
@ -2175,6 +2175,30 @@ def test_update_marks_preparation_stale_when_candidate_cannot_be_rebuilt(
assert report["fix_candidate"] is None
def test_update_keeps_preparation_ready_for_pr_text_only_edit(
report_state: ReportState,
) -> None:
"""The pull-request body is not part of the reviewed candidate, so editing it
alone cannot invalidate a ready preparation."""
_seed_weak_report(report_state)
report = report_state.vulnerability_reports[0]
report["fix_candidate"] = {
"security_invariant": "Parametrize the query.",
"draft_edits": [],
}
report["fix_preparation"] = {"state": "ready", "candidate_digest": "0" * 64}
result = _do_update(
report_id="vuln-0009",
update_reason="Polishing the pull request body.",
fields={"fix_pr_body": "## Fix\nEncode output."},
)
assert result["success"] is True
assert report["fix_pr_body"] == "## Fix\nEncode output."
assert report["fix_preparation"]["state"] == "ready"
def _seed_saved_report(report_state: ReportState) -> Path:
"""The weak report, written to disk the way a filed finding is."""
_seed_weak_report(report_state)