skillhub/cli/test/unit/clients/skillhub-client.test.ts

import { describe, expect, test } from 'bun:test'
import { SkillHubClient } from '../../../src/clients/skillhub-client'
import { CliError } from '../../../src/shared/errors'
import { EXIT } from '../../../src/shared/constants'

describe('SkillHubClient', () => {
  test('uses the provided multipart file name when publishing', async () => {
    const fetchImpl = (async (_input: URL | RequestInfo, init?: RequestInit) => {
      const formData = init?.body as FormData
      const file = formData.get('file') as File
      expect(file.name).toBe('custom-skill.zip')
      expect(formData.get('visibility')).toBe('PRIVATE')
      return Response.json({
        data: {
          namespace: 'team',
          slug: 'custom-skill',
          version: '1.0.0',
          visibility: 'PRIVATE'
        }
      })
    }) as unknown as typeof fetch

    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    await expect(client.publish('team', new Blob(['zip'], { type: 'application/zip' }), 'PRIVATE', 'custom-skill.zip'))
      .resolves.toMatchObject({ slug: 'custom-skill' })
  })

  // --- download() error handling (P0) ---

  test('download() throws auth error on 401', async () => {
    const fetchImpl = (async () => new Response(null, { status: 401 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const err = expect(client.download('ns', 'slug')).rejects
    await err.toBeInstanceOf(CliError)
    await err.toHaveProperty('message', 'authentication failed')
    await err.toHaveProperty('exitCode', EXIT.auth)
  })

  test('download() preserves the server reason and request ID on 403', async () => {
    const fetchImpl = (async () => Response.json({
      code: 403,
      msg: 'API token is missing required scope: skill:read',
      requestId: 'req-download'
    }, { status: 403 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    await expect(client.download('ns', 'slug')).rejects.toMatchObject({
      message: 'API token is missing required scope: skill:read',
      exitCode: EXIT.auth,
      details: {
        registry: 'http://registry.test',
        requestId: 'req-download'
      }
    })
  })

  test('download() uses a neutral access error for an unstructured 403', async () => {
    const fetchImpl = (async () => new Response(null, { status: 403 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    await expect(client.download('ns', 'slug')).rejects.toMatchObject({
      message: 'access denied',
      exitCode: EXIT.auth,
      details: { registry: 'http://registry.test' }
    })
  })

  test('download() throws not-found error on 404', async () => {
    const fetchImpl = (async () => new Response(null, { status: 404 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const err = expect(client.download('ns', 'slug')).rejects
    await err.toBeInstanceOf(CliError)
    await err.toHaveProperty('message', 'skill or version not found')
    await err.toHaveProperty('exitCode', EXIT.generic)
  })

  test('download() throws generic error on 400', async () => {
    const fetchImpl = (async () => new Response(null, { status: 400 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const err = expect(client.download('ns', 'slug')).rejects
    await err.toBeInstanceOf(CliError)
    await err.toHaveProperty('message', 'download failed with status 400')
    await err.toHaveProperty('exitCode', EXIT.generic)
  })

  test('download() throws generic error on 500', async () => {
    const fetchImpl = (async () => new Response(null, { status: 500 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const err = expect(client.download('ns', 'slug')).rejects
    await err.toBeInstanceOf(CliError)
    await err.toHaveProperty('message', 'download failed with status 500')
    await err.toHaveProperty('exitCode', EXIT.generic)
  })

  test('download() retains its fallback while classifying 502 as a network error', async () => {
    const fetchImpl = (async () => new Response(null, { status: 502 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    await expect(client.download('ns', 'slug')).rejects.toMatchObject({
      message: 'download failed with status 502',
      exitCode: EXIT.network,
      details: { registry: 'http://registry.test' }
    })
  })

  test('download() throws network error on fetch failure', async () => {
    const fetchImpl = (async () => { throw new TypeError('fetch failed') }) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const err = expect(client.download('ns', 'slug')).rejects
    await err.toBeInstanceOf(CliError)
    await err.toHaveProperty('message', 'registry unreachable')
    await err.toHaveProperty('exitCode', EXIT.network)
  })

  // --- whoami() (P1) ---

  test('whoami() returns user data', async () => {
    const fetchImpl = (async () => Response.json({
      data: { handle: 'alice', displayName: 'Alice', email: 'a@b.com' }
    })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const result = await client.whoami()
    expect(result).toEqual({ handle: 'alice', displayName: 'Alice', email: 'a@b.com' })
  })

  test('whoami() throws on 401', async () => {
    const fetchImpl = (async () => new Response(null, { status: 401 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const err = expect(client.whoami()).rejects
    await err.toBeInstanceOf(CliError)
    await err.toHaveProperty('message', 'authentication failed')
    await err.toHaveProperty('exitCode', EXIT.auth)
  })

  // --- search() (P1) ---

  test('search() returns items', async () => {
    const fetchImpl = (async () => Response.json({
      data: {
        items: [{ namespace: 'g', slug: 's', latestVersion: '1.0', summary: 'x' }],
        total: 1,
        limit: 20
      }
    })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const result = await client.search('test', 20)
    expect(result.items).toHaveLength(1)
    expect(result.items[0]).toEqual({ namespace: 'g', slug: 's', latestVersion: '1.0', summary: 'x' })
    expect(result.total).toBe(1)
    expect(result.limit).toBe(20)
  })

  test('search() returns empty results', async () => {
    const fetchImpl = (async () => Response.json({
      data: { items: [], total: 0, limit: 20 }
    })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const result = await client.search('nothing', 20)
    expect(result.items).toHaveLength(0)
    expect(result.total).toBe(0)
  })

  // --- resolve() (P1) ---

  test('resolve() without version omits query param', async () => {
    let capturedUrl = ''
    const fetchImpl = (async (input: URL | RequestInfo) => {
      capturedUrl = String(input)
      return Response.json({
        data: { namespace: 'ns', slug: 'sk', version: '1.0.0', versionId: 1, fingerprint: 'abc', downloadUrl: '/dl' }
      })
    }) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    await client.resolve('ns', 'sk')
    expect(capturedUrl).not.toContain('?version=')
  })

  test('resolve() with version includes query param', async () => {
    let capturedUrl = ''
    const fetchImpl = (async (input: URL | RequestInfo) => {
      capturedUrl = String(input)
      return Response.json({
        data: { namespace: 'ns', slug: 'sk', version: '2.0.0', versionId: 2, fingerprint: 'def', downloadUrl: '/dl' }
      })
    }) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    await client.resolve('ns', 'sk', '2.0.0')
    expect(capturedUrl).toContain('?version=2.0.0')
  })

  // --- handleJsonResponse() non-2xx classification ---

  test('whoami() preserves public fields and ignores unknown fields on a structured 401', async () => {
    const fetchImpl = (async () => Response.json({
      code: 401,
      msg: 'token has been revoked',
      requestId: 'req-401',
      detail: 'internal token state',
      stack: 'internal stack trace'
    }, { status: 401 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    const error = await client.whoami().catch((caught: unknown) => caught)
    expect(error).toBeInstanceOf(CliError)
    expect((error as CliError).message).toBe('token has been revoked')
    expect((error as CliError).exitCode).toBe(EXIT.auth)
    expect((error as CliError).details).toEqual({
      registry: 'http://registry.test',
      requestId: 'req-401',
      next: 'run `skillhub login`'
    })
  })

  test('search() preserves a public 403 message and request ID', async () => {
    const fetchImpl = (async () => Response.json({
      code: 403,
      msg: 'token has been revoked',
      requestId: 'req-403'
    }, { status: 403 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    try {
      await client.search('test', 20)
      throw new Error('expected search to fail')
    } catch (error) {
      expect(error).toBeInstanceOf(CliError)
      expect((error as CliError).message).toBe('token has been revoked')
      expect((error as CliError).exitCode).toBe(EXIT.auth)
      expect((error as CliError).details).toEqual({
        registry: 'http://registry.test',
        requestId: 'req-403'
      })
    }
  })

  test('search() uses a neutral 403 fallback when msg is absent', async () => {
    const fetchImpl = (async () => Response.json({
      code: 403,
      requestId: 'req-fallback'
    }, { status: 403 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    try {
      await client.search('test', 20)
      throw new Error('expected search to fail')
    } catch (error) {
      expect(error).toBeInstanceOf(CliError)
      expect((error as CliError).message).toBe('access denied')
      expect((error as CliError).exitCode).toBe(EXIT.auth)
      expect((error as CliError).details).toEqual({
        registry: 'http://registry.test',
        requestId: 'req-fallback'
      })
    }
  })

  test('search() uses a neutral 403 fallback for a non-JSON body', async () => {
    const fetchImpl = (async () => new Response('<html>forbidden</html>', {
      status: 403,
      headers: { 'Content-Type': 'text/html' }
    })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    try {
      await client.search('test', 20)
      throw new Error('expected search to fail')
    } catch (error) {
      expect(error).toBeInstanceOf(CliError)
      expect((error as CliError).message).toBe('access denied')
      expect((error as CliError).exitCode).toBe(EXIT.auth)
      expect((error as CliError).details).toEqual({ registry: 'http://registry.test' })
    }
  })

  test('whoami() preserves a structured 404 message and request ID', async () => {
    const fetchImpl = (async () => Response.json({
      code: 404,
      msg: 'namespace not found',
      requestId: 'req-404'
    }, { status: 404 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    try {
      await client.whoami()
      throw new Error('expected whoami to fail')
    } catch (error) {
      expect(error).toBeInstanceOf(CliError)
      expect((error as CliError).message).toBe('namespace not found')
      expect((error as CliError).exitCode).toBe(EXIT.generic)
      expect((error as CliError).details).toEqual({
        registry: 'http://registry.test',
        requestId: 'req-404'
      })
    }
  })

  test('whoami() uses the resource fallback on an unstructured 404', async () => {
    const fetchImpl = (async () => new Response(null, { status: 404 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    await expect(client.whoami()).rejects.toMatchObject({
      message: 'resource not found',
      exitCode: EXIT.generic,
      details: { registry: 'http://registry.test' }
    })
  })

  test('download() preserves a structured 403 message and request ID', async () => {
    const fetchImpl = (async () => Response.json({
      code: 403,
      msg: 'namespace access denied',
      requestId: 'req-download'
    }, { status: 403 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    try {
      await client.download('team', 'private-skill')
      throw new Error('expected download to fail')
    } catch (error) {
      expect(error).toBeInstanceOf(CliError)
      expect((error as CliError).message).toBe('namespace access denied')
      expect((error as CliError).exitCode).toBe(EXIT.auth)
      expect((error as CliError).details).toEqual({
        registry: 'http://registry.test',
        requestId: 'req-download'
      })
    }
  })

  test('whoami() surfaces server reason and request ID on 403', async () => {
    const fetchImpl = (async () => Response.json({
      code: 403,
      msg: 'API token cannot access endpoint: /api/cli/v1/whoami',
      requestId: 'req-610'
    }, { status: 403 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    await expect(client.whoami()).rejects.toMatchObject({
      message: 'API token cannot access endpoint: /api/cli/v1/whoami',
      exitCode: EXIT.auth,
      details: {
        registry: 'http://registry.test',
        requestId: 'req-610'
      }
    })
  })

  test('whoami() falls back to generic access denied when 403 body is invalid', async () => {
    const fetchImpl = (async () => new Response('not-json', { status: 403 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    await expect(client.whoami()).rejects.toMatchObject({
      message: 'access denied',
      exitCode: EXIT.auth,
      details: { registry: 'http://registry.test' }
    })
  })

  test('whoami() preserves public fields on a structured 500', async () => {
    const fetchImpl = (async () => Response.json({
      code: 500,
      msg: 'registry operation failed',
      requestId: 'req-500',
      detail: 'internal database error'
    }, { status: 500 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    await expect(client.whoami()).rejects.toMatchObject({
      message: 'registry operation failed',
      exitCode: EXIT.generic,
      details: {
        registry: 'http://registry.test',
        requestId: 'req-500'
      }
    })
  })

  test('whoami() does not expose a raw non-JSON 500 body', async () => {
    const fetchImpl = (async () => new Response('internal stack trace', { status: 500 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    await expect(client.whoami()).rejects.toMatchObject({
      message: 'registry returned 500',
      exitCode: EXIT.generic,
      details: { registry: 'http://registry.test' }
    })
  })

  test('search() preserves public fields and network classification on a structured 502', async () => {
    const fetchImpl = (async () => Response.json({
      code: 502,
      msg: 'registry upstream unavailable',
      requestId: 'req-502'
    }, { status: 502 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    await expect(client.search('test', 20)).rejects.toMatchObject({
      message: 'registry upstream unavailable',
      exitCode: EXIT.network,
      details: {
        registry: 'http://registry.test',
        requestId: 'req-502'
      }
    })
  })

  test('search() uses the network fallback on an unstructured 502', async () => {
    const fetchImpl = (async () => new Response(null, { status: 502 })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)

    await expect(client.search('test', 20)).rejects.toMatchObject({
      message: 'registry returned 502',
      exitCode: EXIT.network,
      details: { registry: 'http://registry.test' }
    })
  })

  // --- deleteRemote() (P1) ---

  test('deleteRemote() returns result on success', async () => {
    const fetchImpl = (async () => Response.json({
      data: { ok: true, scope: 'remote', action: 'delete', namespace: 'global', slug: 'demo' }
    })) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const result = await client.deleteRemote('global', 'demo')
    expect(result).toEqual({ ok: true, scope: 'remote', action: 'delete', namespace: 'global', slug: 'demo' })
  })

  test('deleteRemote() throws on network error', async () => {
    const fetchImpl = (async () => { throw new TypeError('fetch failed') }) as unknown as typeof fetch
    const client = new SkillHubClient('http://registry.test', 'token', fetchImpl)
    const err = expect(client.deleteRemote('global', 'demo')).rejects
    await err.toBeInstanceOf(CliError)
    await err.toHaveProperty('message', 'registry unreachable')
    await err.toHaveProperty('exitCode', EXIT.network)
  })
})