mirror of
https://github.com/iflytek/skillhub.git
synced 2026-08-28 11:25:00 +00:00
e249db35a3
- Add integration tests for doctor, install, list, publish, remove, whoami commands - Expand fake-registry with resolve/delete state capture for real assertions - Fix update command: use correct package name @astron-team/skillhub from constants - Refactor runUpdateCommand to accept string[] instead of fragile string splitting - Add dependency injection to updateCommand for testable unit tests without global mocks - Replace package.json import with codegen (scripts/generate-pkg-info.ts) to avoid leaking devDependencies into the build artifact - Fix startNetworkFailureServer TOCTOU race by keeping listener alive - Add TODO markers for known help command bugs (--json not forwarded, unknown topic crash) - Extend update integration test timeout for real npm registry checks
66 lines
3.1 KiB
TypeScript
66 lines
3.1 KiB
TypeScript
import { describe, expect, test } from 'bun:test'
|
|
import { runCli } from '../helpers/run-cli'
|
|
|
|
describe('help command', () => {
|
|
test('prints detailed help for install', async () => {
|
|
const result = await runCli(['help', 'install'])
|
|
expect(result.exitCode).toBe(0)
|
|
expect(result.stdout).toContain('Usage: skillhub install <slug>')
|
|
expect(result.stdout).toContain('--agent <profile>')
|
|
})
|
|
|
|
test('prints search help with optional query', async () => {
|
|
const result = await runCli(['help', 'search'])
|
|
expect(result.exitCode).toBe(0)
|
|
expect(result.stdout).toContain('Usage: skillhub search [query]')
|
|
expect(result.stdout).toContain('skillhub search')
|
|
})
|
|
|
|
// P1: bare `skillhub help` (no topic) prints the directory of all commands
|
|
test('bare help lists all commands in human format', async () => {
|
|
const result = await runCli(['help'])
|
|
expect(result.exitCode).toBe(0)
|
|
// Sample at least 6 of the 12 known commands appear in the output
|
|
for (const name of ['login', 'logout', 'search', 'install', 'list', 'publish']) {
|
|
expect(result.stdout).toContain(name)
|
|
}
|
|
})
|
|
|
|
// P1: `skillhub help --json` is wired in cac but the --json flag is consumed
|
|
// by the action wrapper and never reaches helpCommand's args. Today this
|
|
// makes the JSON branch unreachable from the CLI surface (helpCommand always
|
|
// sees [] or [topic] without --json). We document the current human-only
|
|
// behavior here so a future source fix that re-routes --json into
|
|
// helpCommand will fail this test loudly and we can convert it into a
|
|
// positive JSON assertion at that time.
|
|
// TODO source bug: cli/src/index.ts:178 should forward --json into helpCommand args.
|
|
test('help --json currently returns human directory (documents source bug)', async () => {
|
|
const result = await runCli(['help', '--json'])
|
|
expect(result.exitCode).toBe(0)
|
|
// Output is NOT valid JSON today.
|
|
let isJson = true
|
|
try { JSON.parse(result.stdout) } catch { isJson = false }
|
|
expect(isJson).toBe(false)
|
|
// Sanity: human output still mentions some commands
|
|
expect(result.stdout).toContain('install')
|
|
})
|
|
|
|
test('help <topic> --json currently returns human topic detail (documents source bug)', async () => {
|
|
const result = await runCli(['help', 'install', '--json'])
|
|
expect(result.exitCode).toBe(0)
|
|
let isJson = true
|
|
try { JSON.parse(result.stdout) } catch { isJson = false }
|
|
expect(isJson).toBe(false)
|
|
expect(result.stdout).toContain('Usage: skillhub install')
|
|
})
|
|
|
|
// P1: `skillhub help <unknown>` currently crashes inside helpCommand because
|
|
// `commands[topic]` is undefined and `detail.usage` dereferences undefined.
|
|
// We assert non-zero exit so that a future fix to graceful handling does not
|
|
// regress silently. TODO source bug: cli/src/commands/help.ts:75 should
|
|
// surface a friendlier "unknown command" message instead of crashing.
|
|
test('help <unknown-topic> exits non-zero (documents current crashy behavior)', async () => {
|
|
const result = await runCli(['help', 'definitely-not-a-command'])
|
|
expect(result.exitCode).not.toBe(0)
|
|
})
|
|
})
|