From 9644d50fbb0436fb8e342a1cd0a0db377e7f8ce4 Mon Sep 17 00:00:00 2001 From: dongmucat <1127093059@qq.com> Date: Tue, 14 Apr 2026 14:02:48 +0800 Subject: [PATCH] Revert "fix(review): allow super admins to approve own promotions" This reverts commit 738f8b33b852832c21ea3ba776a6eea4707b8042. --- .../skillhub/domain/review/ReviewPermissionChecker.java | 2 +- .../domain/review/ReviewPermissionCheckerTest.java | 8 -------- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/server/skillhub-domain/src/main/java/com/iflytek/skillhub/domain/review/ReviewPermissionChecker.java b/server/skillhub-domain/src/main/java/com/iflytek/skillhub/domain/review/ReviewPermissionChecker.java index 634e5893..bc5dae42 100644 --- a/server/skillhub-domain/src/main/java/com/iflytek/skillhub/domain/review/ReviewPermissionChecker.java +++ b/server/skillhub-domain/src/main/java/com/iflytek/skillhub/domain/review/ReviewPermissionChecker.java @@ -107,7 +107,7 @@ public class ReviewPermissionChecker { String userId, Set platformRoles) { if (request.getSubmittedBy().equals(userId)) { - return platformRoles.contains("SUPER_ADMIN"); + return false; } return hasPlatformReviewRole(platformRoles); } diff --git a/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/review/ReviewPermissionCheckerTest.java b/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/review/ReviewPermissionCheckerTest.java index 020744b2..21fc18dc 100644 --- a/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/review/ReviewPermissionCheckerTest.java +++ b/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/review/ReviewPermissionCheckerTest.java @@ -198,12 +198,4 @@ class ReviewPermissionCheckerTest { assertFalse(checker.canReviewPromotion(req, userId, Set.of("SKILL_ADMIN"))); } - - @Test - void superAdminCanReviewOwnPromotion() { - String userId = "user-2"; - PromotionRequest req = new PromotionRequest(1L, 1L, 1L, userId); - assertTrue(checker.canReviewPromotion(req, userId, - Set.of("SUPER_ADMIN"))); - } }