diff --git a/server/skillhub-auth/src/main/java/com/iflytek/skillhub/auth/oauth/IdentityProviderRouteReadinessFilter.java b/server/skillhub-auth/src/main/java/com/iflytek/skillhub/auth/oauth/IdentityProviderRouteReadinessFilter.java index 19b74ad2..8ead2c02 100644 --- a/server/skillhub-auth/src/main/java/com/iflytek/skillhub/auth/oauth/IdentityProviderRouteReadinessFilter.java +++ b/server/skillhub-auth/src/main/java/com/iflytek/skillhub/auth/oauth/IdentityProviderRouteReadinessFilter.java @@ -55,7 +55,7 @@ public final class IdentityProviderRouteReadinessFilter ? null : registrationRepository.findByRegistrationId(registrationId); if (registration == null) { - response.sendError(HttpServletResponse.SC_FORBIDDEN); + response.setStatus(HttpServletResponse.SC_FORBIDDEN); return; } @@ -70,14 +70,14 @@ public final class IdentityProviderRouteReadinessFilter "Identity provider route '{}' rejected before upstream I/O: {}", registration.getRegistrationId(), exception.getReasonCode()); - response.sendError(status); + response.setStatus(status); return; } catch (RuntimeException exception) { log.error( "Identity provider route '{}' readiness check failed", registration.getRegistrationId(), exception); - response.sendError( + response.setStatus( HttpServletResponse.SC_SERVICE_UNAVAILABLE); return; } diff --git a/server/skillhub-auth/src/test/java/com/iflytek/skillhub/auth/oauth/IdentityProviderRouteReadinessFilterTest.java b/server/skillhub-auth/src/test/java/com/iflytek/skillhub/auth/oauth/IdentityProviderRouteReadinessFilterTest.java index a66dcd86..0cf7ae02 100644 --- a/server/skillhub-auth/src/test/java/com/iflytek/skillhub/auth/oauth/IdentityProviderRouteReadinessFilterTest.java +++ b/server/skillhub-auth/src/test/java/com/iflytek/skillhub/auth/oauth/IdentityProviderRouteReadinessFilterTest.java @@ -71,6 +71,7 @@ class IdentityProviderRouteReadinessFilterTest { filter.doFilter(request, response, chain); assertThat(response.getStatus()).isEqualTo(503); + assertThat(response.isCommitted()).isFalse(); verify(chain, never()).doFilter(request, response); } @@ -89,6 +90,7 @@ class IdentityProviderRouteReadinessFilterTest { filter.doFilter(request, response, chain); assertThat(response.getStatus()).isEqualTo(403); + assertThat(response.isCommitted()).isFalse(); verify(chain, never()).doFilter(request, response); } @@ -104,6 +106,7 @@ class IdentityProviderRouteReadinessFilterTest { filter.doFilter(request, response, chain); assertThat(response.getStatus()).isEqualTo(403); + assertThat(response.isCommitted()).isFalse(); verify(readinessService, never()) .requireReady(registration); verify(chain, never()).doFilter(request, response);