scriptoriumadmin/skillhub
1
0
Fork 0
mirror of https://github.com/iflytek/skillhub.git synced 2026-10-10 03:27:54 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

test(promotion): cover unpublished sources and version races

Browse source 
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
This commit is contained in:
XiaoSeS 2026-10-09 18:28:39 +08:00
parent 2732bc6dea
commit 863e240838
1 changed files with 48 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

54
server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/review/PromotionServiceTest.java
View file

@ -216,13 +216,17 @@ class PromotionServiceTest {
void shouldThrowWhenVersionNotPublished() {
Skill sourceSkill = createSourceSkill();
SkillVersion sv = createPublishedVersion();
sv.setStatus(SkillVersionStatus.DRAFT);
when(skillRepository.findById(SOURCE_SKILL_ID)).thenReturn(Optional.of(sourceSkill));
when(skillVersionRepository.findById(SOURCE_VERSION_ID)).thenReturn(Optional.of(sv));
assertThrows(DomainBadRequestException.class,
() -> promotionService.submitPromotion(SOURCE_SKILL_ID, SOURCE_VERSION_ID, TARGET_NAMESPACE_ID, USER_ID, Map.of()));
for (SkillVersionStatus status : List.of(SkillVersionStatus.DRAFT,
SkillVersionStatus.PENDING_REVIEW, SkillVersionStatus.REJECTED, SkillVersionStatus.YANKED)) {
sv.setStatus(status);
assertThrows(DomainBadRequestException.class,
() -> promotionService.submitPromotion(SOURCE_SKILL_ID, SOURCE_VERSION_ID,
TARGET_NAMESPACE_ID, USER_ID, Map.of()));
}
}
@Test
@ -742,11 +746,16 @@ class PromotionServiceTest {
when(promotionRequestRepository.findActiveInitialBySourceSkillId(SOURCE_SKILL_ID))
.thenReturn(Optional.of(initialLink()));
when(skillRepository.findById(NEW_SKILL_ID)).thenReturn(Optional.of(linkedTarget()));
SkillVersion occupied = new SkillVersion(NEW_SKILL_ID, version.getVersion(), USER_ID);
when(skillVersionRepository.findBySkillIdAndVersion(NEW_SKILL_ID, version.getVersion()))
.thenReturn(Optional.of(new SkillVersion(NEW_SKILL_ID, version.getVersion(), USER_ID)));
.thenReturn(Optional.of(occupied));
assertThrows(DomainBadRequestException.class, () -> promotionService.submitPromotion(
SOURCE_SKILL_ID, SOURCE_VERSION_ID, TARGET_NAMESPACE_ID, USER_ID, Map.of()));
for (SkillVersionStatus status : List.of(SkillVersionStatus.DRAFT,
SkillVersionStatus.PENDING_REVIEW, SkillVersionStatus.PUBLISHED)) {
occupied.setStatus(status);
assertThrows(DomainBadRequestException.class, () -> promotionService.submitPromotion(
SOURCE_SKILL_ID, SOURCE_VERSION_ID, TARGET_NAMESPACE_ID, USER_ID, Map.of()));
}
verify(promotionRequestRepository, never()).save(any(PromotionRequest.class));
}
@ -822,6 +831,39 @@ class PromotionServiceTest {
verify(skillRepository, times(1)).save(target);
verify(entityManager).lock(target, jakarta.persistence.LockModeType.PESSIMISTIC_WRITE);
}
@Test
void rejectsUpdateApprovalWhenGlobalVersionWasOccupiedAfterSubmission() {
PromotionRequest pending = createPendingPromotion();
pending.setRequestKind(PromotionRequestKind.UPDATE);
pending.setTargetSkillId(NEW_SKILL_ID);
PromotionRequest approved = approvedPromotion(pending, "approved");
approved.setRequestKind(PromotionRequestKind.UPDATE);
approved.setTargetSkillId(NEW_SKILL_ID);
Skill target = linkedTarget();
SkillVersion sourceVersion = createPublishedVersion();
when(promotionRequestRepository.findById(PROMOTION_ID))
.thenReturn(Optional.of(pending), Optional.of(approved));
when(permissionChecker.canReviewPromotion(pending, REVIEWER_ID, Set.of("SKILL_ADMIN")))
.thenReturn(true);
when(promotionRequestRepository.updateStatusWithVersion(
PROMOTION_ID, ReviewTaskStatus.APPROVED, REVIEWER_ID, "approved",
NEW_SKILL_ID, pending.getVersion())).thenReturn(1);
when(skillRepository.findById(SOURCE_SKILL_ID)).thenReturn(Optional.of(createSourceSkill()));
when(skillVersionRepository.findById(SOURCE_VERSION_ID)).thenReturn(Optional.of(sourceVersion));
when(promotionRequestRepository.findActiveInitialBySourceSkillId(SOURCE_SKILL_ID))
.thenReturn(Optional.of(initialLink()));
when(skillRepository.findById(NEW_SKILL_ID)).thenReturn(Optional.of(target));
when(skillVersionRepository.findBySkillIdAndVersion(NEW_SKILL_ID, sourceVersion.getVersion()))
.thenReturn(Optional.of(new SkillVersion(NEW_SKILL_ID, sourceVersion.getVersion(), USER_ID)));
DomainBadRequestException error = assertThrows(DomainBadRequestException.class,
() -> promotionService.approvePromotion(PROMOTION_ID, REVIEWER_ID, "approved",
Set.of("SKILL_ADMIN"), Set.of()));
assertEquals("promotion.target_version_conflict", error.messageCode());
verify(entityManager).lock(target, jakarta.persistence.LockModeType.PESSIMISTIC_WRITE);
verify(skillVersionRepository, never()).save(any(SkillVersion.class));
}
}
@Test