From 6cee2fedd533efb809f9c629669f5e4eb9f204c4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=8D=83=E4=B9=98=E5=A6=8D=20=28Xiaoyaner=29?=
 <258399167+xiaoyaner0201@users.noreply.github.com>
Date: Fri, 30 Oct 2026 00:25:38 +0800
Subject: [PATCH] test(chart): pass analytics JSON through a values file
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Helm --set-string parses {...} as a list, so the enabled-analytics
contract case failed schema validation in CI. Use a values file, the
same way the operator guide documents the setting.

Refs #989

Signed-off-by: 千乘妍 (Xiaoyaner) <258399167+xiaoyaner0201@users.noreply.github.com>
---
 charts/skillhub/tests/configuration-contracts.sh | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/charts/skillhub/tests/configuration-contracts.sh b/charts/skillhub/tests/configuration-contracts.sh
index 72d5cef4c..d28009f21 100755
--- a/charts/skillhub/tests/configuration-contracts.sh
+++ b/charts/skillhub/tests/configuration-contracts.sh
@@ -476,9 +476,15 @@ assert_rejected subpath-reserved-analytics-nested --set-string web.basePath=/_sk
 
 render analytics-default "$CHART_DIR" >"$TMP_DIR/analytics-default.yaml"
 grep -Fq 'web-analytics-config: ""' "$TMP_DIR/analytics-default.yaml" || fail "analytics must default off"
-render analytics-enabled "$CHART_DIR" \
-  --set-string web.analytics.config='{"enabled":true}' \
-  --set-string web.analytics.upstream=https://stats.example.com >"$TMP_DIR/analytics-enabled.yaml"
+# --set treats {...} as a list, so pass the JSON string through a values file,
+# the same way the operator guide documents it.
+cat >"$TMP_DIR/analytics-values.yaml" <<'VALUES'
+web:
+  analytics:
+    config: '{"enabled":true,"adapter":"umami","consent":"granted","adapterConfig":{"websiteId":"4398de8e-40df-4483-9eea-ed213643525f"}}'
+    upstream: https://stats.example.com
+VALUES
+render analytics-enabled "$CHART_DIR" -f "$TMP_DIR/analytics-values.yaml" >"$TMP_DIR/analytics-enabled.yaml"
 for key in SKILLHUB_WEB_ANALYTICS_CONFIG SKILLHUB_WEB_ANALYTICS_UPSTREAM; do
   grep -Fq "name: $key" "$TMP_DIR/analytics-enabled.yaml" || fail "missing analytics environment"
 done