From 56e9e0ebd9c65009feb1abd762a0269f87a9d6e1 Mon Sep 17 00:00:00 2001
From: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
Date: Wed, 2 Sep 2026 02:48:56 +0800
Subject: [PATCH] fix(review): disable edits for archived skills

Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
---
 .../skill/service/SkillQueryService.java      |  3 +-
 .../skill/service/SkillQueryServiceTest.java  | 29 +++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)

diff --git a/server/skillhub-domain/src/main/java/com/iflytek/skillhub/domain/skill/service/SkillQueryService.java b/server/skillhub-domain/src/main/java/com/iflytek/skillhub/domain/skill/service/SkillQueryService.java
index c7a86cd7..d115e485 100644
--- a/server/skillhub-domain/src/main/java/com/iflytek/skillhub/domain/skill/service/SkillQueryService.java
+++ b/server/skillhub-domain/src/main/java/com/iflytek/skillhub/domain/skill/service/SkillQueryService.java
@@ -242,7 +242,8 @@ public class SkillQueryService {
                 skill.getUpdatedAt(),
                 canManageRestrictedSkill(skill, currentUserId, userNsRoles),
                 canSubmitPromotion(namespace, skill, publishedVersion, currentUserId, userNsRoles),
-                headlineVersion == null || "PUBLISHED".equals(headlineVersion.status()),
+                skill.getStatus() == SkillStatus.ACTIVE
+                        && (headlineVersion == null || "PUBLISHED".equals(headlineVersion.status())),
                 currentUserId == null || !Objects.equals(skill.getOwnerId(), currentUserId),
                 headlineVersion,
                 publishedVersion,
diff --git a/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/skill/service/SkillQueryServiceTest.java b/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/skill/service/SkillQueryServiceTest.java
index 7fb08e3c..ac49f1d8 100644
--- a/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/skill/service/SkillQueryServiceTest.java
+++ b/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/skill/service/SkillQueryServiceTest.java
@@ -1212,6 +1212,35 @@ class SkillQueryServiceTest {
         assertTrue(result.canInteract());
     }
 
+    @Test
+    void testGetSkillDetail_ShouldDisableInteractionForArchivedSkill() throws Exception {
+        String namespaceSlug = "test-ns";
+        String skillSlug = "test-skill";
+        String ownerId = "owner-1";
+        Map<Long, NamespaceRole> userNsRoles = Map.of();
+
+        Namespace namespace = new Namespace(namespaceSlug, "Test NS", ownerId);
+        setId(namespace, 1L);
+        Skill skill = new Skill(1L, skillSlug, ownerId, SkillVisibility.PUBLIC);
+        setId(skill, 1L);
+        skill.setStatus(SkillStatus.ARCHIVED);
+        skill.setLatestVersionId(11L);
+
+        SkillVersion published = new SkillVersion(1L, "1.0.0", ownerId);
+        setId(published, 11L);
+        published.setStatus(SkillVersionStatus.PUBLISHED);
+
+        when(namespaceRepository.findBySlug(namespaceSlug)).thenReturn(Optional.of(namespace));
+        when(skillRepository.findByNamespaceIdAndSlug(1L, skillSlug)).thenReturn(List.of(skill));
+        when(skillVersionRepository.findById(11L)).thenReturn(Optional.of(published));
+
+        SkillQueryService.SkillDetailDTO result = service.getSkillDetail(namespaceSlug, skillSlug, ownerId, userNsRoles);
+
+        assertNotNull(result.headlineVersion());
+        assertEquals("PUBLISHED", result.headlineVersion().status());
+        assertFalse(result.canInteract());
+    }
+
     @Test
     void testGetSkillDetail_ShouldIncludeRejectedOwnerPreviewComment() throws Exception {
         String namespaceSlug = "test-ns";