scriptoriumadmin/skillhub
1
0
Fork 0
mirror of https://github.com/iflytek/skillhub.git synced 2026-08-27 11:14:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix(promotion): copy bundleReady and downloadReady when promoting skill to global

Browse source 
When approving a promotion, the new SkillVersion was created without copying
bundleReady and downloadReady from the source version, causing the download
button to be permanently disabled for promoted skills.
This commit is contained in:
dongmucat 2026-05-14 11:38:35 +08:00
parent 5ccb7f9cf7
commit 2af0bf184b
2 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
server/skillhub-domain/src/main/java/com/iflytek/skillhub/domain/review/PromotionService.java
View file

@ -234,6 +234,8 @@ public class PromotionService {
newVersion.setManifestJson(sourceVersion.getManifestJson());
newVersion.setFileCount(sourceVersion.getFileCount());
newVersion.setTotalSize(sourceVersion.getTotalSize());
newVersion.setBundleReady(sourceVersion.isBundleReady());
newVersion.setDownloadReady(sourceVersion.isDownloadReady());
newVersion = skillVersionRepository.save(newVersion);
// Update skill's latest version

4
server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/review/PromotionServiceTest.java
View file

@ -91,6 +91,8 @@ class PromotionServiceTest {
sv.setManifestJson("{\"version\":\"1.0.0\"}");
sv.setFileCount(3);
sv.setTotalSize(1024L);
sv.setBundleReady(true);
sv.setDownloadReady(true);
return sv;
}
@ -466,6 +468,8 @@ class PromotionServiceTest {
assertEquals(3, newVersion.getFileCount());
assertEquals(1024L, newVersion.getTotalSize());
assertEquals(Instant.now(CLOCK), newVersion.getPublishedAt());
assertTrue(newVersion.isBundleReady());
assertTrue(newVersion.isDownloadReady());
// Verify files copied
@SuppressWarnings("unchecked")