scriptoriumadmin/skillhub
1
0
Fork 0
mirror of https://github.com/iflytek/skillhub.git synced 2026-10-05 02:41:49 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

test(suite): cover version validation entry points

Browse source 
Signed-off-by: XiaoSeS <87064762+XiaoSeS@users.noreply.github.com>
This commit is contained in:
XiaoSeS 2026-09-10 09:13:41 +08:00
parent 83ff64d76a
commit 24f07913ac
1 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/suite/SkillSuiteDraftServiceTest.java
View file

@ -129,15 +129,23 @@ class SkillSuiteDraftServiceTest {
}
@Test
void rejectsSuiteVersionsThatCannotBeUsedSafelyAcrossCliShells() {
void rejectsUnsafeSuiteVersionsAtEveryDraftWriteEntryPoint() {
Namespace namespace = new Namespace("team", "Team", "owner");
setId(namespace, 1L);
SkillSuite suite = new SkillSuite(1L, "writers", "Writers", "author");
setId(suite, 10L);
when(namespaceRepository.findById(1L)).thenReturn(Optional.of(namespace));
when(suiteRepository.findById(10L)).thenReturn(Optional.of(suite));
SkillSuiteActionContext context = new SkillSuiteActionContext(
"author", Map.of(1L, NamespaceRole.MEMBER), Set.of(),
"request-3", "127.0.0.1", "test");
for (String version : List.of("1.0.0; touch pwned", "a".repeat(65))) {
SkillSuiteVersion existingVersion = new SkillSuiteVersion(
10L, version, SkillVisibility.PUBLIC, "author");
setId(existingVersion, 20L);
when(versionRepository.findByIdForDefinitionUpdate(20L))
.thenReturn(Optional.of(existingVersion));
CreateSkillSuiteDraftCommand command = new CreateSkillSuiteDraftCommand(
1L, "writers", "Writers", "Summary", null, version,
SkillVisibility.PUBLIC, null, 40L,
@ -147,6 +155,12 @@ class SkillSuiteDraftServiceTest {
assertThatThrownBy(() -> service.create(command, context))
.isInstanceOf(DomainBadRequestException.class)
.hasMessage("error.suite.version.invalid");
assertThatThrownBy(() -> service.createVersion(10L, command, context))
.isInstanceOf(DomainBadRequestException.class)
.hasMessage("error.suite.version.invalid");
assertThatThrownBy(() -> service.updateDraft(10L, 20L, command, context))
.isInstanceOf(DomainBadRequestException.class)
.hasMessage("error.suite.version.invalid");
}
}