From 142685610aa89c10fe302c57efd8ddf269dfd3fd Mon Sep 17 00:00:00 2001 From: yun-zhi-ztl Date: Sat, 14 Mar 2026 17:52:56 +0800 Subject: [PATCH] fix(test): update ReviewPermissionCheckerTest for stricter self-review policy After merge, HEAD's ReviewPermissionChecker prohibits all self-review (including SKILL_ADMIN/SUPER_ADMIN). Updated tests to reflect this stricter security model from A2. --- .../domain/review/ReviewPermissionCheckerTest.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/review/ReviewPermissionCheckerTest.java b/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/review/ReviewPermissionCheckerTest.java index 189a7d1f..6ba7a4de 100644 --- a/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/review/ReviewPermissionCheckerTest.java +++ b/server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/review/ReviewPermissionCheckerTest.java @@ -26,18 +26,18 @@ class ReviewPermissionCheckerTest { } @Test - void skillAdminCanReviewOwnSubmission() { + void skillAdminCannotReviewOwnSubmission() { String userId = "user-1"; ReviewTask task = new ReviewTask(1L, 10L, userId); - assertTrue(checker.canReview(task, userId, + assertFalse(checker.canReview(task, userId, NamespaceType.TEAM, Map.of(), Set.of("SKILL_ADMIN"))); } @Test - void superAdminCanReviewOwnSubmission() { + void superAdminCannotReviewOwnSubmission() { String userId = "user-1"; ReviewTask task = new ReviewTask(1L, 10L, userId); - assertTrue(checker.canReview(task, userId, + assertFalse(checker.canReview(task, userId, NamespaceType.TEAM, Map.of(), Set.of("SUPER_ADMIN"))); }