scriptoriumadmin/skillhub
1
0
Fork 0
mirror of https://github.com/iflytek/skillhub.git synced 2026-08-27 11:14:59 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

fix: add support for .cjs and .mjs JavaScript extensions (#285)

Browse source
This commit is contained in:
Uğur Tafralı 2026-04-11 06:15:36 +03:00 • committed by GitHub
parent 3e1b5738aa
commit 02b3ac5b62
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 29 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
docs/07-skill-protocol.md
View file

@ -67,7 +67,7 @@ my-skill/
校验规则：
- 根目录必须包含 `SKILL.md`
- 文件类型白名单：`.md`, `.txt`, `.json`, `.yaml`, `.yml`, `.js`, `.ts`, `.py`, `.sh`, `.png`, `.jpg`, `.svg`
- 文件类型白名单：`.md`, `.txt`, `.json`, `.yaml`, `.yml`, `.js`, `.cjs`, `.mjs`, `.ts`, `.py`, `.sh`, `.png`, `.jpg`, `.svg`
- 单文件大小限制：1MB（可配置）
- 总包大小限制：10MB（可配置）
- 文件数量限制：100 个（可配置）

2
server/skillhub-app/src/main/java/com/iflytek/skillhub/controller/support/SkillPackageArchiveExtractor.java
View file

@ -136,7 +136,7 @@ public class SkillPackageArchiveExtractor {
if (lower.endsWith(".css")) return "text/css";
if (lower.endsWith(".csv")) return "text/csv";
if (lower.endsWith(".xml")) return "application/xml";
if (lower.endsWith(".js")) return "text/javascript";
if (lower.endsWith(".js") || lower.endsWith(".cjs") || lower.endsWith(".mjs")) return "text/javascript";
if (lower.endsWith(".ts")) return "text/typescript";
if (lower.endsWith(".sh") || lower.endsWith(".bash") || lower.endsWith(".zsh")) return "text/x-shellscript";
if (lower.endsWith(".png")) return "image/png";

5
server/skillhub-domain/src/main/java/com/iflytek/skillhub/domain/skill/validation/SkillPackagePolicy.java
View file

@ -25,7 +25,7 @@ public final class SkillPackagePolicy {
// Configuration and schemas
".toml", ".xml", ".xsd", ".xsl", ".dtd", ".ini", ".cfg", ".env",
// Scripts and source code
".js", ".ts", ".py", ".sh", ".rb", ".go", ".rs", ".java", ".kt",
".js", ".cjs", ".mjs", ".ts", ".py", ".sh", ".rb", ".go", ".rs", ".java", ".kt",
".lua", ".sql", ".r", ".bat", ".ps1", ".zsh", ".bash",
// Images
".png", ".jpg", ".jpeg", ".svg", ".gif", ".webp", ".ico",
@ -126,7 +126,8 @@ public final class SkillPackagePolicy {
private static boolean isTextExtension(String path) {
return path.endsWith(".md") || path.endsWith(".txt")
|| path.endsWith(".json") || path.endsWith(".yaml") || path.endsWith(".yml")
|| path.endsWith(".js") || path.endsWith(".ts") || path.endsWith(".py") || path.endsWith(".sh")
|| path.endsWith(".js") || path.endsWith(".cjs") || path.endsWith(".mjs")
|| path.endsWith(".ts") || path.endsWith(".py") || path.endsWith(".sh")
|| path.endsWith(".html") || path.endsWith(".css") || path.endsWith(".csv")
|| path.endsWith(".toml") || path.endsWith(".xml") || path.endsWith(".xsd")
|| path.endsWith(".xsl") || path.endsWith(".dtd") || path.endsWith(".ini")

24
server/skillhub-domain/src/test/java/com/iflytek/skillhub/domain/skill/validation/SkillPackageValidatorTest.java
View file

@ -309,6 +309,30 @@ class SkillPackageValidatorTest {
assertTrue(result.passed());
}
@Test
void acceptsCjsFile() {
byte[] cjsContent = "module.exports = {};".getBytes();
List<PackageEntry> entries = List.of(
skillMdEntry(),
new PackageEntry("index.cjs", cjsContent, cjsContent.length, "text/javascript")
);
ValidationResult result = validator.validate(entries);
assertTrue(result.passed());
assertTrue(result.errors().isEmpty());
}
@Test
void acceptsMjsFile() {
byte[] mjsContent = "export default {};".getBytes();
List<PackageEntry> entries = List.of(
skillMdEntry(),
new PackageEntry("index.mjs", mjsContent, mjsContent.length, "text/javascript")
);
ValidationResult result = validator.validate(entries);
assertTrue(result.passed());
assertTrue(result.errors().isEmpty());
}
private PackageEntry skillMdEntry() {
String skillMdContent = """
---