mirror of
https://github.com/open-webui/open-webui.git
synced 2026-09-20 00:11:27 +00:00
has_access_to_file runs for every non-owner file GET, per RAG file check and per shared-chat or model-attached file. Its final step called Models.get_models_by_user_id, which issued one grant query per non-owned workspace model, so a single file check on an instance with M workspace models cost M grant queries plus a group query, with the deny path always paying full price. Its collection_name step listed every knowledge base the user can access (itself one grant query per knowledge base) just to scan the list for one id. And get_accessible_folder_files repeated the whole pipeline per folder entry, refetching the caller's group memberships every time. Three changes, all using parameters and helpers that already exist: - Models.get_models_by_user_id resolves grants for all non-owned models in one get_accessible_resource_ids call and accepts prefetched user_group_ids. - The collection_name check fetches the one referenced knowledge base and performs a single owner-or-grant check with the already-resolved group ids, preserving the write-requires-owner guard exactly (including its short-circuit before any grant query). - get_accessible_folder_files resolves group ids once and threads them through every per-entry check. Benchmark: | metric | before | after | | --- | --- | --- | | filter loop CPU, 300 workspace models (queries stubbed) | 47 us | 19 us | | grant queries per file-access check, M workspace models | M | 1 | | group membership queries per folder listing, F files | F | 1 | The stubbed CPU row understates the win: each removed query in the other two rows was a real database round trip. Functionally verified with stubbed accessors: owned plus granted models are returned with owned ids excluded from the batch query; model-attached file access resolves through the batched path; the collection_name path does one KB fetch and one grant check with no full listing; a missing KB falls through; write access via a KB still requires the KB owner to own the file and short-circuits before the grant query; folder listings fetch groups exactly once.
153 lines
5.9 KiB
Python
153 lines
5.9 KiB
Python
import logging
|
|
|
|
from open_webui.models.access_grants import AccessGrants
|
|
from open_webui.models.channels import Channels
|
|
from open_webui.models.chats import Chats
|
|
from open_webui.models.files import Files
|
|
from open_webui.models.groups import Groups
|
|
from open_webui.models.knowledge import Knowledges
|
|
from open_webui.models.models import Models
|
|
from open_webui.models.users import UserModel
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
log = logging.getLogger(__name__)
|
|
|
|
|
|
async def has_access_to_file(
|
|
file_id: str | None,
|
|
access_type: str,
|
|
user: UserModel,
|
|
db: AsyncSession | None = None,
|
|
user_group_ids: set[str] | None = None,
|
|
) -> bool:
|
|
"""
|
|
Check if a user has the specified access to a file through any of:
|
|
- Knowledge bases (ownership or access grants)
|
|
- Shared workspace models that attach the file directly
|
|
- Channels the user is a member of
|
|
- Shared chats
|
|
|
|
NOTE: This does NOT check direct file ownership — callers should check
|
|
file.user_id == user.id separately before calling this.
|
|
"""
|
|
file = await Files.get_file_by_id(file_id, db=db)
|
|
log.debug(f'Checking if user has {access_type} access to file')
|
|
if not file:
|
|
return False
|
|
|
|
# Direct ownership
|
|
if file.user_id == user.id:
|
|
return True
|
|
|
|
# Check if the file is associated with any knowledge bases the user has access to.
|
|
# An object (knowledge base or workspace model) confers write/delete on a file only when
|
|
# the object's OWNER owns that file; otherwise a read-only file laundered into an object
|
|
# the user controls would gain write/delete on it (CWE-863). Read access is unaffected.
|
|
knowledge_bases = await Knowledges.get_knowledges_by_file_id(file_id, db=db)
|
|
if user_group_ids is None:
|
|
user_group_ids = {group.id for group in await Groups.get_groups_by_member_id(user.id, db=db)}
|
|
for knowledge_base in knowledge_bases:
|
|
if (
|
|
knowledge_base.user_id == user.id
|
|
or await AccessGrants.has_access(
|
|
user_id=user.id,
|
|
resource_type='knowledge',
|
|
resource_id=knowledge_base.id,
|
|
permission=access_type,
|
|
user_group_ids=user_group_ids,
|
|
db=db,
|
|
)
|
|
) and (access_type == 'read' or knowledge_base.user_id == file.user_id):
|
|
return True
|
|
|
|
knowledge_base_id = file.meta.get('collection_name') if file.meta else None
|
|
if knowledge_base_id:
|
|
# Fetch the one referenced knowledge base instead of listing every
|
|
# knowledge base the user can access just to scan for this id.
|
|
knowledge_base = await Knowledges.get_knowledge_by_id(knowledge_base_id, db=db)
|
|
if (
|
|
knowledge_base
|
|
and (access_type == 'read' or knowledge_base.user_id == file.user_id)
|
|
and (
|
|
knowledge_base.user_id == user.id
|
|
or await AccessGrants.has_access(
|
|
user_id=user.id,
|
|
resource_type='knowledge',
|
|
resource_id=knowledge_base.id,
|
|
permission=access_type,
|
|
user_group_ids=user_group_ids,
|
|
db=db,
|
|
)
|
|
)
|
|
):
|
|
return True
|
|
|
|
# Check if the file is associated with any channels the user has access to
|
|
channels = await Channels.get_channels_by_file_id_and_user_id(file_id, user.id, db=db)
|
|
if access_type == 'read' and channels:
|
|
return True
|
|
|
|
# Check if the file is associated with any chats the user has access to
|
|
shared_chat_ids = await Chats.get_shared_chat_ids_by_file_id(file_id, db=db)
|
|
if access_type == 'read' and shared_chat_ids:
|
|
accessible_ids = await AccessGrants.get_accessible_resource_ids(
|
|
user_id=user.id,
|
|
resource_type='shared_chat',
|
|
resource_ids=shared_chat_ids,
|
|
permission='read',
|
|
user_group_ids=user_group_ids,
|
|
db=db,
|
|
)
|
|
if accessible_ids:
|
|
return True
|
|
|
|
# Check if the file is directly attached to a shared workspace model (per the ownership
|
|
# note above, model write is conferred only for files the model owner owns).
|
|
for model in await Models.get_models_by_user_id(
|
|
user.id, permission=access_type, db=db, user_group_ids=user_group_ids
|
|
):
|
|
knowledge_items = getattr(model.meta, 'knowledge', None) or []
|
|
for item in knowledge_items:
|
|
if isinstance(item, dict) and item.get('type') == 'file' and item.get('id') == file.id:
|
|
if access_type == 'read' or model.user_id == file.user_id:
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
async def get_accessible_folder_files(
|
|
entries: list[dict] | None,
|
|
user: UserModel,
|
|
db: AsyncSession | None = None,
|
|
) -> list[dict]:
|
|
"""Filter folder.data['files'] entries to those the caller can read.
|
|
|
|
Each entry is expected to have 'type' ('file' or 'collection') and 'id'.
|
|
Admins bypass all checks. Unknown types are kept as-is.
|
|
"""
|
|
if not entries:
|
|
return []
|
|
if user.role == 'admin':
|
|
return list(entries)
|
|
|
|
# One group-membership fetch for the whole folder listing
|
|
user_group_ids = {group.id for group in await Groups.get_groups_by_member_id(user.id, db=db)}
|
|
|
|
accessible: list[dict] = []
|
|
for entry in entries:
|
|
if not isinstance(entry, dict):
|
|
continue
|
|
entry_type = entry.get('type')
|
|
entry_id = entry.get('id')
|
|
if not entry_id:
|
|
accessible.append(entry)
|
|
continue
|
|
if entry_type == 'file':
|
|
if await has_access_to_file(entry_id, 'read', user, db=db, user_group_ids=user_group_ids):
|
|
accessible.append(entry)
|
|
elif entry_type == 'collection':
|
|
if await Knowledges.check_access_by_user_id(entry_id, user.id, 'read', db=db):
|
|
accessible.append(entry)
|
|
else:
|
|
accessible.append(entry)
|
|
return accessible
|