mirror of
https://github.com/open-webui/open-webui.git
synced 2026-09-16 23:43:03 +00:00
get_accessible_folder_files is the server-side filter that reduces a folder's attached-knowledge list (and, once #26723 lands, a direct model's) to the entries the caller may read, before that list is handed to the builtin knowledge tools as `__model_knowledge__`. It validated `file` and `collection` entries but passed `note` entries through unchecked (they fell into the `else` keep-as-is branch), even though notes are a first-class attached-knowledge type that flows through this list. No current caller is exploitable, because every note consumer (`query_knowledge_files`, `view_note`, and the legacy retrieval path) independently re-checks note access before returning content. But relying on each consumer to remember that check is exactly the fragility this helper exists to remove, and the same `_has_read_access_to_file` membership short-circuit that makes an unvalidated `file` entry dangerous would turn any future note path that trusts list membership into an IDOR. Validate notes here so the filter enforces its own contract instead of leaning on downstream re-checks. A note entry is now kept only when the caller owns it or holds a read grant. Notes are private by default and carry no self-grant, so ownership is checked explicitly alongside the grant lookup. Admins still bypass all checks and genuinely unknown types are still kept as-is. Related: #26723
170 lines
6.6 KiB
Python
170 lines
6.6 KiB
Python
import logging
|
|
|
|
from open_webui.models.access_grants import AccessGrants
|
|
from open_webui.models.channels import Channels
|
|
from open_webui.models.chats import Chats
|
|
from open_webui.models.files import Files
|
|
from open_webui.models.groups import Groups
|
|
from open_webui.models.knowledge import Knowledges
|
|
from open_webui.models.models import Models
|
|
from open_webui.models.users import UserModel
|
|
from sqlalchemy.ext.asyncio import AsyncSession
|
|
|
|
log = logging.getLogger(__name__)
|
|
|
|
|
|
async def has_access_to_file(
|
|
file_id: str | None,
|
|
access_type: str,
|
|
user: UserModel,
|
|
db: AsyncSession | None = None,
|
|
user_group_ids: set[str] | None = None,
|
|
) -> bool:
|
|
"""
|
|
Check if a user has the specified access to a file through any of:
|
|
- Knowledge bases (ownership or access grants)
|
|
- Shared workspace models that attach the file directly
|
|
- Channels the user is a member of
|
|
- Shared chats
|
|
|
|
NOTE: This does NOT check direct file ownership — callers should check
|
|
file.user_id == user.id separately before calling this.
|
|
"""
|
|
file = await Files.get_file_by_id(file_id, db=db)
|
|
log.debug(f'Checking if user has {access_type} access to file')
|
|
if not file:
|
|
return False
|
|
|
|
# Direct ownership
|
|
if file.user_id == user.id:
|
|
return True
|
|
|
|
# Check if the file is associated with any knowledge bases the user has access to.
|
|
# An object (knowledge base or workspace model) confers write/delete on a file only when
|
|
# the object's OWNER owns that file; otherwise a read-only file laundered into an object
|
|
# the user controls would gain write/delete on it (CWE-863). Read access is unaffected.
|
|
knowledge_bases = await Knowledges.get_knowledges_by_file_id(file_id, db=db)
|
|
if user_group_ids is None:
|
|
user_group_ids = {group.id for group in await Groups.get_groups_by_member_id(user.id, db=db)}
|
|
for knowledge_base in knowledge_bases:
|
|
if (
|
|
knowledge_base.user_id == user.id
|
|
or await AccessGrants.has_access(
|
|
user_id=user.id,
|
|
resource_type='knowledge',
|
|
resource_id=knowledge_base.id,
|
|
permission=access_type,
|
|
user_group_ids=user_group_ids,
|
|
db=db,
|
|
)
|
|
) and (access_type == 'read' or knowledge_base.user_id == file.user_id):
|
|
return True
|
|
|
|
knowledge_base_id = file.meta.get('collection_name') if file.meta else None
|
|
if knowledge_base_id:
|
|
# Fetch the one referenced knowledge base instead of listing every
|
|
# knowledge base the user can access just to scan for this id.
|
|
knowledge_base = await Knowledges.get_knowledge_by_id(knowledge_base_id, db=db)
|
|
if (
|
|
knowledge_base
|
|
and (access_type == 'read' or knowledge_base.user_id == file.user_id)
|
|
and (
|
|
knowledge_base.user_id == user.id
|
|
or await AccessGrants.has_access(
|
|
user_id=user.id,
|
|
resource_type='knowledge',
|
|
resource_id=knowledge_base.id,
|
|
permission=access_type,
|
|
user_group_ids=user_group_ids,
|
|
db=db,
|
|
)
|
|
)
|
|
):
|
|
return True
|
|
|
|
# Check if the file is associated with any channels the user has access to
|
|
channels = await Channels.get_channels_by_file_id_and_user_id(file_id, user.id, db=db)
|
|
if access_type == 'read' and channels:
|
|
return True
|
|
|
|
# Check if the file is associated with any chats the user has access to
|
|
shared_chat_ids = await Chats.get_shared_chat_ids_by_file_id(file_id, db=db)
|
|
if access_type == 'read' and shared_chat_ids:
|
|
accessible_ids = await AccessGrants.get_accessible_resource_ids(
|
|
user_id=user.id,
|
|
resource_type='shared_chat',
|
|
resource_ids=shared_chat_ids,
|
|
permission='read',
|
|
user_group_ids=user_group_ids,
|
|
db=db,
|
|
)
|
|
if accessible_ids:
|
|
return True
|
|
|
|
# Check if the file is directly attached to a shared workspace model (per the ownership
|
|
# note above, model write is conferred only for files the model owner owns).
|
|
for model in await Models.get_models_by_user_id(
|
|
user.id, permission=access_type, db=db, user_group_ids=user_group_ids
|
|
):
|
|
knowledge_items = getattr(model.meta, 'knowledge', None) or []
|
|
for item in knowledge_items:
|
|
if isinstance(item, dict) and item.get('type') == 'file' and item.get('id') == file.id:
|
|
if access_type == 'read' or model.user_id == file.user_id:
|
|
return True
|
|
|
|
return False
|
|
|
|
|
|
async def get_accessible_folder_files(
|
|
entries: list[dict] | None,
|
|
user: UserModel,
|
|
db: AsyncSession | None = None,
|
|
) -> list[dict]:
|
|
"""Filter folder.data['files'] entries to those the caller can read.
|
|
|
|
Entries carry a 'type' ('file', 'collection' or 'note') and 'id'. File, collection and
|
|
note ids are each access-checked against the caller; admins bypass all checks and
|
|
genuinely unknown types are kept as-is.
|
|
"""
|
|
if not entries:
|
|
return []
|
|
if user.role == 'admin':
|
|
return list(entries)
|
|
|
|
# One group-membership fetch for the whole folder listing
|
|
user_group_ids = {group.id for group in await Groups.get_groups_by_member_id(user.id, db=db)}
|
|
|
|
accessible: list[dict] = []
|
|
for entry in entries:
|
|
if not isinstance(entry, dict):
|
|
continue
|
|
entry_type = entry.get('type')
|
|
entry_id = entry.get('id')
|
|
if not entry_id:
|
|
accessible.append(entry)
|
|
continue
|
|
if entry_type == 'file':
|
|
if await has_access_to_file(entry_id, 'read', user, db=db, user_group_ids=user_group_ids):
|
|
accessible.append(entry)
|
|
elif entry_type == 'collection':
|
|
if await Knowledges.check_access_by_user_id(entry_id, user.id, 'read', db=db):
|
|
accessible.append(entry)
|
|
elif entry_type == 'note':
|
|
# Owner has no self-grant (notes are private by default), so check ownership too.
|
|
from open_webui.models.notes import Notes
|
|
|
|
note = await Notes.get_note_by_id(entry_id, db=db)
|
|
if note and (
|
|
note.user_id == user.id
|
|
or await AccessGrants.has_access(
|
|
user_id=user.id,
|
|
resource_type='note',
|
|
resource_id=entry_id,
|
|
permission='read',
|
|
db=db,
|
|
)
|
|
):
|
|
accessible.append(entry)
|
|
else:
|
|
accessible.append(entry)
|
|
return accessible
|