scriptoriumadmin/open-webui
1
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-09-28 01:31:28 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: offload blocking storage and file reads to worker thread

Browse source 
Storage.get_file and local file reads can perform sync network/disk I/O
for remote backends (S3/GCS/Azure), stalling the event loop during
chat-triggered uploads. Run them via asyncio.to_thread and pass bytes
to the FormData field instead of a sync file handle.
This commit is contained in:
DrMelone 2026-04-12 23:22:58 +02:00
parent b2b0702eea
commit f165f7dc3d
1 changed files with 28 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

48
backend/open_webui/tools/builtin.py
View file

@ -2830,6 +2830,11 @@ async def delete_automation(
# =============================================================================
def _read_file_bytes(path: str) -> bytes:
with open(path, 'rb') as fh:
return fh.read()
async def upload_file_to_terminal(
file_id: str,
__request__: Request = None,
@ -2922,7 +2927,11 @@ async def upload_file_to_terminal(
):
return json.dumps({'error': 'File not found'})
local_path = Storage.get_file(file_record.path)
# Storage.get_file and file reads can do sync network/disk I/O for
# remote backends (S3/GCS/Azure); offload to a worker thread to keep
# the event loop responsive under concurrent chat load.
local_path = await asyncio.to_thread(Storage.get_file, file_record.path)
file_bytes = await asyncio.to_thread(_read_file_bytes, local_path)
# --- 3. Upload to terminal server ---
import aiohttp
@ -2950,25 +2959,24 @@ async def upload_file_to_terminal(
f'to {terminal_url}/files/upload?directory={upload_dir}'
)
with open(local_path, 'rb') as fh:
form_data = aiohttp.FormData()
form_data.add_field('file', fh, filename=file_record.filename)
async with session.post(
f'{terminal_url}/files/upload',
params={'directory': upload_dir},
data=form_data,
headers=headers,
cookies=cookies,
) as response:
if not (200 <= response.status < 300):
detail = (await response.text())[:500]
return json.dumps(
{'error': f'Upload failed (HTTP {response.status}): {detail}'}
)
try:
result = await response.json()
except Exception:
result = {}
form_data = aiohttp.FormData()
form_data.add_field('file', file_bytes, filename=file_record.filename)
async with session.post(
f'{terminal_url}/files/upload',
params={'directory': upload_dir},
data=form_data,
headers=headers,
cookies=cookies,
) as response:
if not (200 <= response.status < 300):
detail = (await response.text())[:500]
return json.dumps(
{'error': f'Upload failed (HTTP {response.status}): {detail}'}
)
try:
result = await response.json()
except Exception:
result = {}
return json.dumps(
{