chore: remove the Show Files on Terminal Select setting (#33855)

This commit is contained in:
G30 2026-11-07 02:47:42 -05:00 • committed by GitHub
parent 22bce6021e
commit def1d048bc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
8 changed files with 1 additions and 53 deletions

View file

@ -101,7 +101,6 @@ class InterfaceSettings(BaseModel):
splitLargeChunks: bool | None = None
scrollOnBranchChange: bool | None = None
scrollOnResponseGeneration: bool | None = None
showFilesOnTerminalSelect: bool | None = None
temporaryChatByDefault: bool | None = None
userLocation: bool | None = None
showChatTitleInTab: bool | None = None

View file

@ -5554,7 +5554,6 @@
class=" pb-2 {dragged ? 'z-0' : 'z-10'}"
>
<MessageInput
{fullWidthTabs}
{terminalContext}
{typingUsers}
on:typing={(event) => emitTyping(event.detail)}
@ -5656,7 +5655,6 @@
{/if}
<div id={embedded ? messageInputDropzoneId : undefined} class="pb-2 z-10">
<MessageInput
{fullWidthTabs}
{terminalContext}
{typingUsers}
on:typing={(event) => emitTyping(event.detail)}
@ -5727,7 +5725,6 @@
{:else}
<div class="flex items-center h-full">
<Placeholder
{fullWidthTabs}
chatId={$chatId}
{terminalContext}
callActive={!!(bridge?.connected || bridge?.connecting)}

View file

@ -921,7 +921,6 @@
$sideChatRequest?.parentId === chatId
)
sideChatRequest.set(null);
$: if ($showTabs === 'files' && showFilesTab) openFiles();
$: if ($showTabs === 'side') {
if (canSideChat) openFeature('side');
else sideChatRequest.set(null);

View file

@ -167,7 +167,6 @@
export let onTemporaryChange: ((value: boolean) => void) | null = null;
$: isTemporary = temporary ?? $temporaryChatEnabled;
export let terminalContext: TerminalContext | null = null;
export let fullWidthTabs = false;
export let terminalSelectionEnabled = true;
export let contextUsage = null;
export let contextCompactionEnabled = false;
@ -2840,7 +2839,6 @@
<!-- Terminal Server Selector -->
{#if showTerminalSelector}
<TerminalMenu
{fullWidthTabs}
bind:show={showTerminalMenu}
disabled={generating ||
(!!history?.currentId &&

View file

@ -4,9 +4,7 @@
import {
chatId as activeChatId,
config,
mobile,
settings,
showTabs,
showSettings,
terminalServers,
selectedTerminalId,
@ -24,7 +22,6 @@
export let show = false;
export let disabled = false;
export let fullWidthTabs = false;
const chatContext = (terminal: any) => terminal?.contexts?.chat ?? {};
@ -70,9 +67,6 @@
const selectDirect = async (terminal: (typeof directTerminals)[0]) => {
const newId = $selectedTerminalId === terminal.url ? null : terminal.url;
selectedTerminalId.set(newId);
if (newId && !$mobile && !fullWidthTabs) {
showTabs.set(($settings?.showFilesOnTerminalSelect ?? true) ? 'files' : false);
}
// Enable the selected direct terminal, disable all others
const updatedServers = ($settings?.terminalServers ?? []).map((s) => ({
@ -94,9 +88,6 @@
const selectSystem = async (terminal: (typeof systemTerminals)[0]) => {
const newId = $selectedTerminalId === terminal.id ? null : terminal.id;
selectedTerminalId.set(newId);
if (newId && !$mobile && !fullWidthTabs) {
showTabs.set(($settings?.showFilesOnTerminalSelect ?? true) ? 'files' : false);
}
// Disable all direct terminals when switching to a system terminal
if ($settings?.terminalServers?.some((s) => s.enabled)) {

View file

@ -57,7 +57,6 @@
export let prompt = '';
export let files = [];
export let terminalContext: TerminalContext | null = null;
export let fullWidthTabs = false;
export let messageInput = null;
export let selectedToolIds = [];
@ -260,7 +259,6 @@
<div class="text-base font-normal @md:max-w-3xl w-full py-3 {atSelectedModel ? 'mt-2' : ''}">
{#if !($selectedFolder && folderReadOnly)}
<MessageInput
{fullWidthTabs}
{chatId}
{terminalContext}
{callActive}

View file

@ -56,7 +56,6 @@
let splitLargeChunks = false;
let scrollOnBranchChange = true;
let scrollOnResponseGeneration = true;
let showFilesOnTerminalSelect = true;
let terminalFileDisplay: 'sidebar' | 'inline' = 'sidebar';
let userLocation = false;
@ -381,7 +380,6 @@
splitLargeChunks = currentSettings?.splitLargeChunks ?? false;
scrollOnBranchChange = currentSettings?.scrollOnBranchChange ?? true;
scrollOnResponseGeneration = currentSettings?.scrollOnResponseGeneration ?? true;
showFilesOnTerminalSelect = currentSettings?.showFilesOnTerminalSelect ?? true;
terminalFileDisplay = currentSettings?.terminalFileDisplay === 'inline' ? 'inline' : 'sidebar';
temporaryChatByDefault = currentSettings?.temporaryChatByDefault ?? false;
@ -1544,33 +1542,6 @@
</p>
</div>
<div>
<div class={settingRowClass}>
<label
id="show-files-on-terminal-select-label"
class={settingLabelClass}
for="show-files-on-terminal-select-label-control"
>
{$i18n.t('settings.personal.interface.showFilesOnTerminalSelect.label')}
</label>
<div class={settingControlClass}>
<Switch
ariaLabelledbyId="show-files-on-terminal-select-label"
tooltip={true}
bind:state={showFilesOnTerminalSelect}
inherited={isDefaultSetting('showFilesOnTerminalSelect')}
on:change={() => {
saveSettings({ showFilesOnTerminalSelect });
}}
/>
</div>
</div>
<p class={settingDescriptionClass}>
{$i18n.t('settings.personal.interface.showFilesOnTerminalSelect.description')}
</p>
</div>
<div>
<div class={settingRowClass}>
<label

View file

@ -175,11 +175,7 @@ export const showSettings: Writable<boolean | string | SettingsModalRequest> = w
export const showChangelog = writable(false);
export const showTabs = writable<
| boolean
| 'files'
| 'comments'
| 'side'
| (CommentTarget & { tab: 'comments'; comment_id?: string })
boolean | 'comments' | 'side' | (CommentTarget & { tab: 'comments'; comment_id?: string })
>(false);
export const showEmbeds = writable(false);
export const showOverview = writable(false);
@ -316,7 +312,6 @@ type Settings = {
terminalPreviewAllowSameOrigin?: boolean;
scrollOnBranchChange?: boolean;
scrollOnResponseGeneration?: boolean;
showFilesOnTerminalSelect?: boolean;
terminalFileDisplay?: 'sidebar' | 'inline';
directConnections?: null;
chatBubble?: boolean;