scriptoriumadmin/open-webui
1
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-10-28 06:22:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: file viewer tools ignore the end line when no start line is given (#33154)

Browse source 
The view_file and view_knowledge_file built-in tools let a model ask for a start and end line, but passing only the end line did nothing: the tool returned the first block of characters and dropped the end line without a word. Models that asked for "up to line N" kept getting the same opening slice and no error, so they retried the call over and over. An end line on its own now reads from line 1 up to that line, the same result as passing start line 1 explicitly.

Fixes #33100
This commit is contained in:
Classic298 2026-10-25 06:08:51 +01:00 • committed by GitHub
parent a01b36afe8
commit d378fe81cb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
backend/open_webui/tools/builtin.py
View file

@ -2844,7 +2844,7 @@ async def view_file(
:param max_chars: Maximum characters to return (a server-side hard cap applies)
:param line_numbers: If true, prefix each line with its 1-indexed line number
:param start_line: Optional 1-indexed start line (overrides offset/max_chars when set)
:param end_line: Optional 1-indexed end line (inclusive)
:param end_line: Optional 1-indexed end line (inclusive; reads from line 1 if no start line is given)
:return: JSON with the file's id, filename, content, and pagination metadata if truncated
"""
if __request__ is None:
@ -2886,10 +2886,10 @@ async def view_file(
total_chars = len(content)
# Line-based addressing (overrides char-based offset/max_chars)
if start_line is not None:
if start_line is not None or end_line is not None:
all_lines = content.split('\n')
total_lines = len(all_lines)
s = max(1, int(start_line)) - 1 # 1-indexed to 0-indexed
s = max(1, int(start_line or 1)) - 1 # 1-indexed to 0-indexed
e = min(total_lines, int(end_line) if end_line else s + 100)
selected = all_lines[s:e]
sliced = '\n'.join(f'{s + i + 1}: {line}' for i, line in enumerate(selected))
@ -2957,7 +2957,7 @@ async def view_knowledge_file(
:param max_chars: Maximum characters to return (a server-side hard cap applies)
:param line_numbers: If true, prefix each line with its 1-indexed line number
:param start_line: Optional 1-indexed start line (overrides offset/max_chars when set)
:param end_line: Optional 1-indexed end line (inclusive)
:param end_line: Optional 1-indexed end line (inclusive; reads from line 1 if no start line is given)
:return: JSON with the file's id, filename, content, and pagination metadata if truncated
"""
if __request__ is None:
@ -3027,10 +3027,10 @@ async def view_knowledge_file(
total_chars = len(content)
# Line-based addressing (overrides char-based offset/max_chars)
if start_line is not None:
if start_line is not None or end_line is not None:
all_lines = content.split('\n')
total_lines = len(all_lines)
s = max(1, int(start_line)) - 1
s = max(1, int(start_line or 1)) - 1
e = min(total_lines, int(end_line) if end_line else s + 100)
selected = all_lines[s:e]
sliced = '\n'.join(f'{s + i + 1}: {line}' for i, line in enumerate(selected))