From cc6de63bc876f3c3d8116d5d2858e7887b1997b9 Mon Sep 17 00:00:00 2001 From: Classic298 <27028174+Classic298@users.noreply.github.com> Date: Wed, 21 Oct 2026 18:51:44 +0200 Subject: [PATCH] fix: Web Search settings do not save while web search is off (#32840) With web search off, clicking Save on the Web Search settings page jumped to an empty search engine field and saved nothing. That happened with no engine picked, which is how a fresh install starts, and also when an engine picked earlier was missing its own details, such as the SearXNG query URL. Admins could not change the Web Loader settings, which apply whenever a user attaches a web page, without filling in a search engine first. The engine and its details are now only required while web search is turned on. Fixes #32831 --- src/lib/components/admin/Settings/WebSearch.svelte | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/lib/components/admin/Settings/WebSearch.svelte b/src/lib/components/admin/Settings/WebSearch.svelte index 8d69bb8a71..45bf4951c7 100644 --- a/src/lib/components/admin/Settings/WebSearch.svelte +++ b/src/lib/components/admin/Settings/WebSearch.svelte @@ -219,7 +219,7 @@ {#each webSearchEngines as engine} @@ -306,7 +306,7 @@ placeholder={$i18n.t('Enter Searxng Query URL')} bind:value={webConfig.SEARXNG_QUERY_URL} autocomplete="off" - required + required={webConfig.ENABLE_WEB_SEARCH} /> @@ -324,7 +324,7 @@ placeholder={$i18n.t('Enter Searxng search language')} bind:value={webConfig.SEARXNG_LANGUAGE} autocomplete="off" - required + required={webConfig.ENABLE_WEB_SEARCH} /> @@ -361,7 +361,7 @@ class="w-full rounded-lg border border-gray-100/50 bg-gray-50/40 px-2 py-1.5 text-xs text-gray-700 outline-hidden transition-colors focus:border-blue-400 dark:border-white/[0.04] dark:bg-white/[0.03] dark:text-gray-300 dark:focus:border-blue-500" placeholder={$i18n.t('Enter Yacy Username')} bind:value={webConfig.YACY_USERNAME} - required + required={webConfig.ENABLE_WEB_SEARCH} /> @@ -1113,7 +1113,7 @@ placeholder={$i18n.t('Enter OpenSERP Base URL')} bind:value={webConfig.OPENSERP_BASE_URL} autocomplete="off" - required + required={webConfig.ENABLE_WEB_SEARCH} />